From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Last commit breaks macOS build Date: Thu, 05 Jan 2017 18:24:53 +0200 Message-ID: <834m1deap6.fsf@gnu.org> References: <103c5ca4-dba4-9cf1-1c15-535684235be9@alice.it> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1483633820 29430 195.159.176.226 (5 Jan 2017 16:30:20 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 5 Jan 2017 16:30:20 +0000 (UTC) Cc: emacs-devel@gnu.org, angelo.graziosi@alice.it To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jan 05 17:30:16 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cPAva-0006eO-Jk for ged-emacs-devel@m.gmane.org; Thu, 05 Jan 2017 17:30:10 +0100 Original-Received: from localhost ([::1]:47313 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cPAve-0003gw-OR for ged-emacs-devel@m.gmane.org; Thu, 05 Jan 2017 11:30:14 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44298) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cPAqI-0007nA-Ka for emacs-devel@gnu.org; Thu, 05 Jan 2017 11:24:43 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cPAqE-00088O-8T for emacs-devel@gnu.org; Thu, 05 Jan 2017 11:24:42 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:60927) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cPAqE-00088J-53; Thu, 05 Jan 2017 11:24:38 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1053 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cPAqD-000092-As; Thu, 05 Jan 2017 11:24:37 -0500 In-reply-to: (message from Paul Eggert on Wed, 4 Jan 2017 19:21:11 -0800) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:211125 Archived-At: > From: Paul Eggert > Date: Wed, 4 Jan 2017 19:21:11 -0800 > > This is caused by our recent attempt to better-automate MS-Windows builds. I > fixed one nonportable construct, but evidently there are others. Yes, sorry about that. Mea culpa. > It's time to break out a bigger hammer. Please try the attached patch. I have > tested it on Fedora, but not on MS-Windows and so have not installed it yet. I'd prefer to avoid the need for the people who maintain the MS-Windows build to understand the structure of lib/gnulib.mk in too many details, such as what files comprise each Gnulib package, and what is the meaning of the likes of EXTRA_libgnu_a_SOURCES. OTOH, I'd prefer not to bother people who merge from Gnulib with understanding what parts the MS-Windows build needs to avoid. Having a simple list of Gnulib packages to remove from lib/gnulib.mk, similar to nt/gnulib-modules-to-delete.cfg, is therefore preferable to a much more detailed list that you propose to maintain manually in lib/Makefile.am. It is also simpler, since the syntax of Makefile.am doesn't need to be familiar to whoever modifies the list of modules. Is it possible to use a similar plain list of modules while solving this with GNU Make features? If not, I think we should stick with the current solution. It's not a bad one, I think, once we clean up the portability issues. (I just tried to solve a couple of such issues.) Thanks.