all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: emacs-devel@gnu.org, angelo.graziosi@alice.it
Subject: Re: Last commit breaks macOS build
Date: Thu, 05 Jan 2017 18:24:53 +0200	[thread overview]
Message-ID: <834m1deap6.fsf@gnu.org> (raw)
In-Reply-To: <f2f2042a-f1a8-5f8f-63e5-c0b713d86979@cs.ucla.edu> (message from Paul Eggert on Wed, 4 Jan 2017 19:21:11 -0800)

> From: Paul Eggert <eggert@cs.ucla.edu>
> Date: Wed, 4 Jan 2017 19:21:11 -0800
> 
> This is caused by our recent attempt to better-automate MS-Windows builds. I 
> fixed one nonportable construct, but evidently there are others.

Yes, sorry about that.  Mea culpa.

> It's time to break out a bigger hammer. Please try the attached patch. I have 
> tested it on Fedora, but not on MS-Windows and so have not installed it yet.

I'd prefer to avoid the need for the people who maintain the
MS-Windows build to understand the structure of lib/gnulib.mk in too
many details, such as what files comprise each Gnulib package, and
what is the meaning of the likes of EXTRA_libgnu_a_SOURCES.  OTOH, I'd
prefer not to bother people who merge from Gnulib with understanding
what parts the MS-Windows build needs to avoid.

Having a simple list of Gnulib packages to remove from lib/gnulib.mk,
similar to nt/gnulib-modules-to-delete.cfg, is therefore preferable to
a much more detailed list that you propose to maintain manually in
lib/Makefile.am.  It is also simpler, since the syntax of Makefile.am
doesn't need to be familiar to whoever modifies the list of modules.

Is it possible to use a similar plain list of modules while solving
this with GNU Make features?  If not, I think we should stick with the
current solution.  It's not a bad one, I think, once we clean up the
portability issues.  (I just tried to solve a couple of such issues.)

Thanks.



      parent reply	other threads:[~2017-01-05 16:24 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-04 10:08 Last commit breaks macOS build Angelo Graziosi
2017-01-05  3:21 ` Paul Eggert
2017-01-05  9:30   ` Richard Copley
2017-01-05  9:54     ` Angelo Graziosi
2017-01-05 15:42       ` Eli Zaretskii
2017-01-05 16:16       ` Eli Zaretskii
2017-01-05 16:37         ` Angelo Graziosi
2017-01-05 17:04           ` Eli Zaretskii
2017-01-05 17:21             ` Angelo Graziosi
2017-01-05 17:52               ` Eli Zaretskii
2017-01-05 18:18                 ` Andreas Schwab
2017-01-05 18:24                   ` Eli Zaretskii
2017-01-05 18:32                     ` Andreas Schwab
2017-01-05 18:38                       ` Eli Zaretskii
2017-01-05 18:53                         ` Andreas Schwab
2017-01-05 19:38                           ` Eli Zaretskii
2017-01-05 22:41                             ` Angelo Graziosi
2017-01-06  7:45                               ` Eli Zaretskii
2017-01-06 23:33                                 ` Angelo Graziosi
2017-01-06 23:43                                   ` Paul Eggert
2017-01-05 16:24   ` Eli Zaretskii [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=834m1deap6.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=angelo.graziosi@alice.it \
    --cc=eggert@cs.ucla.edu \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.