all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master 885c512: Fix a bug in 'generate-new-buffer-name'
Date: Sat, 05 Aug 2017 18:58:37 +0300	[thread overview]
Message-ID: <834ltmuhua.fsf@gnu.org> (raw)
In-Reply-To: <jwv8tiyaw3b.fsf-monnier+emacsdiffs@gnu.org> (message from Stefan Monnier on Sat, 05 Aug 2017 11:14:30 -0400)

> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: emacs-devel@gnu.org
> Date: Sat, 05 Aug 2017 11:14:30 -0400
> 
> >> > -  if (!NILP (Fstring_equal (name, ignore)) || NILP (Fget_buffer (name)))
> >> > +  if ((!NILP (ignore) && !NILP (Fstring_equal (name, ignore)))
> >> > +      || NILP (Fget_buffer (name)))
> >> Why not just use Fequal instead of Fstring_equal?
> > Because no one said that using a symbol for the IGNORE argument is
> > forbidden in that function.  "nil" just happens to be a special case,
> > but other strings/symbols are allowed.
> 
> I'd be surprised if there is code out there that uses a symbol for the
> `ignore` argument.  And I don't think it's a feature that you can use
> a symbol rather than a string.  I think it's rather a (harmless (except
> for nil)) bug.

Maybe so, but I see no real reason to switch to using Fequal, either.



      reply	other threads:[~2017-08-05 15:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20170805095359.14455.50578@vcs0.savannah.gnu.org>
     [not found] ` <20170805095400.0316E20660@vcs0.savannah.gnu.org>
2017-08-05 12:51   ` [Emacs-diffs] master 885c512: Fix a bug in 'generate-new-buffer-name' Stefan Monnier
2017-08-05 13:02     ` Eli Zaretskii
2017-08-05 15:14       ` Stefan Monnier
2017-08-05 15:58         ` Eli Zaretskii [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=834ltmuhua.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.