From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#5615: 23.1.92; [PATCH] term.el: Calculation of window height is bad (new patch) Date: Fri, 11 Aug 2017 09:32:43 +0300 Message-ID: <834ltesjg4.fsf@gnu.org> References: <4B80CB5A.8080306@yahoo.co.jp> <4BA35102.7050506@yahoo.co.jp> <87oab1tlku.fsf@gnus.org> <87bmnn2aqr.fsf@users.sourceforge.net> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1502433255 19691 195.159.176.226 (11 Aug 2017 06:34:15 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 11 Aug 2017 06:34:15 +0000 (UTC) Cc: larsi@gnus.org, irieshinsuke@yahoo.co.jp, 5615@debbugs.gnu.org To: npostavs@users.sourceforge.net Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Aug 11 08:34:11 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dg3WI-0004fd-MG for geb-bug-gnu-emacs@m.gmane.org; Fri, 11 Aug 2017 08:34:06 +0200 Original-Received: from localhost ([::1]:42350 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dg3WP-00044F-3D for geb-bug-gnu-emacs@m.gmane.org; Fri, 11 Aug 2017 02:34:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44245) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dg3WJ-000440-KQ for bug-gnu-emacs@gnu.org; Fri, 11 Aug 2017 02:34:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dg3WE-0005N2-K8 for bug-gnu-emacs@gnu.org; Fri, 11 Aug 2017 02:34:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:46363) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dg3WE-0005My-FX for bug-gnu-emacs@gnu.org; Fri, 11 Aug 2017 02:34:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dg3WE-0003Nm-3A for bug-gnu-emacs@gnu.org; Fri, 11 Aug 2017 02:34:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 11 Aug 2017 06:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 5615 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 5615-submit@debbugs.gnu.org id=B5615.150243318912933 (code B ref 5615); Fri, 11 Aug 2017 06:34:01 +0000 Original-Received: (at 5615) by debbugs.gnu.org; 11 Aug 2017 06:33:09 +0000 Original-Received: from localhost ([127.0.0.1]:55044 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dg3VM-0003MW-70 for submit@debbugs.gnu.org; Fri, 11 Aug 2017 02:33:08 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:53163) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dg3VK-0003Lx-3X for 5615@debbugs.gnu.org; Fri, 11 Aug 2017 02:33:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dg3V9-00059A-RG for 5615@debbugs.gnu.org; Fri, 11 Aug 2017 02:33:00 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:50753) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dg3V9-000596-Nw; Fri, 11 Aug 2017 02:32:55 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4138 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dg3V8-0004sM-Vd; Fri, 11 Aug 2017 02:32:55 -0400 In-reply-to: <87bmnn2aqr.fsf@users.sourceforge.net> (npostavs@users.sourceforge.net) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:135645 Archived-At: > From: npostavs@users.sourceforge.net > Date: Thu, 10 Aug 2017 20:45:16 -0400 > Cc: IRIE Shinsuke , 5615@debbugs.gnu.org > > Current Emacs still uses the same (1- (window-height)) expression, but I > can't understand from the description when exactly this gives the wrong > result. Furthermore, I don't see any justification which would explain > why the new proposed significantly more complicated computation is more > correct. I think we should just use window-text-height. I think you are right. If no one objects in a few days, please push your change. Thanks.