From: Eli Zaretskii <eliz@gnu.org>
To: Tak Kunihiro <tkk@misasa.okayama-u.ac.jp>
Cc: 27435@debbugs.gnu.org
Subject: bug#27435: patch for dired-mouse-find-file-other-window
Date: Sat, 02 Sep 2017 13:20:06 +0300 [thread overview]
Message-ID: <834lsl1jxl.fsf@gnu.org> (raw)
In-Reply-To: <35B0B760-56DC-43A4-B6C9-B29A51CF4547@misasa.okayama-u.ac.jp> (message from Tak Kunihiro on Mon, 28 Aug 2017 09:22:35 +0900)
> From: Tak Kunihiro <tkk@misasa.okayama-u.ac.jp>
> Date: Mon, 28 Aug 2017 09:22:35 +0900
> Cc: 国広卓也 <tkk@misasa.okayama-u.ac.jp>,
> 27435@debbugs.gnu.org
>
> With the suggestions, I created two functions.
>
> - dired-mouse-find-file (new, this inherits common part)
> - dired-mouse-find-file-other-window
> - dired-mouse-find-file-other-frame (new)
>
> I attach the patch. This does not change the default behavior.
Thanks. Some minor comments:
> +(defun dired-mouse-find-file (event &optional find-file-func find-dir-func)
> + "In Dired, visit the file or directory name you click on.
> +FIND-FILE-FUNC and FIND-DIR-FUNC specify functions to visit the file and directory, respectively."
This last line is too long, please break it into 2. Also, the doc
string should say explicitly these arguments are optional, and what
they default to if omitted or nil.
> + (or find-file-func (setq find-file-func 'find-file))
> + (or find-dir-func (setq find-file-func 'find-alternate-file))
I'm not sure I understand why these particular defaults. Can you
explain? In particular, find-alternate-file sounds strange to me.
Finally, 2 nits:
. please always provide a log message for the changes
. your patch doesn't apply cleanly, presumably due to some
difference in whitespace vs the Git repository; please make sure
your diffs are always against the latest Git version
Thanks.
next prev parent reply other threads:[~2017-09-02 10:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-21 1:41 bug#27435: patch for dired-mouse-find-file-other-window Tak Kunihiro
2017-07-18 4:38 ` Tak Kunihiro
2017-08-26 6:27 ` Tak Kunihiro
2017-08-26 8:09 ` Eli Zaretskii
2017-08-26 9:26 ` Tak Kunihiro
2017-08-26 10:27 ` Eli Zaretskii
2017-08-27 9:02 ` Tak Kunihiro
2017-08-27 12:56 ` Drew Adams
2017-08-27 14:41 ` Eli Zaretskii
2017-08-28 0:22 ` Tak Kunihiro
2017-09-02 10:20 ` Eli Zaretskii [this message]
2017-09-03 2:08 ` Tak Kunihiro
2017-09-08 8:56 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=834lsl1jxl.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=27435@debbugs.gnu.org \
--cc=tkk@misasa.okayama-u.ac.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.