all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Nick Helm <nick@tenpoint.co.nz>
Cc: 28342@debbugs.gnu.org
Subject: bug#28342: 26.0.50; (OSX) Jumpy Scrolling using Trackpad
Date: Sat, 09 Sep 2017 17:25:45 +0300	[thread overview]
Message-ID: <834lscvthy.fsf@gnu.org> (raw)
In-Reply-To: <m2zia7uv56.fsf@tenpoint.co.nz> (message from Nick Helm on Thu, 07 Sep 2017 13:58:45 +1200)

> From: Nick Helm <nick@tenpoint.co.nz>
> Cc: Eli Zaretskii <eliz@gnu.org>
> Date: Thu, 07 Sep 2017 13:58:45 +1200
> 
> The problem might lie in window_scroll_pixel_based in window.c. A small
> tweak seems to help:
> 
> --- src/window.c	2017-09-07 13:16:29.000000000 +1200
> +++ src/window.c	2017-09-07 13:10:04.000000000 +1200
> @@ -4835,7 +4835,7 @@
>  	 have the `scroll-command' property.  This avoids the
>  	 possibility of point becoming "stuck" on a tall line when
>  	 scrolling by one line.  */
> -      if (window_scroll_pixel_based_preserve_y < 0
> +      if (window_scroll_pixel_based_preserve_y <= 0
>  	  || !SYMBOLP (KVAR (current_kboard, Vlast_command))
>  	  || NILP (Fget (KVAR (current_kboard, Vlast_command), Qscroll_command)))
>  	{

Thanks, but this change only fixes the problem when you start
scrolling with point on the first line in the window.  If point is on
2nd, 3rd, or 4th line (more generally, any line inside the
scroll-margin), the bug will still be there.

I installed on master a more general fix, which I hope solves this
problem.





  reply	other threads:[~2017-09-09 14:25 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-04  0:22 bug#28342: 26.0.50; (OSX) Jumpy Scrolling using Trackpad James Nguyen
2017-09-05 20:14 ` Charles A. Roelli
2017-09-06  1:14   ` James Nguyen
2017-09-06  8:53     ` Alan Third
2017-09-06 16:55       ` Eli Zaretskii
2017-09-07  1:58         ` Nick Helm
2017-09-09 14:25           ` Eli Zaretskii [this message]
2017-09-09 14:22         ` Eli Zaretskii
2017-09-10  1:14           ` James Nguyen
2017-09-10  2:40             ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=834lscvthy.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=28342@debbugs.gnu.org \
    --cc=nick@tenpoint.co.nz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.