* bug#28636: 27.0.50; Unable to load color "gtk_selection_bg_color" in 27.0.50 @ 2017-09-28 20:05 aplanas 2017-09-28 20:22 ` Philipp Stephani 0 siblings, 1 reply; 10+ messages in thread From: aplanas @ 2017-09-28 20:05 UTC (permalink / raw To: 28636 A version of Emacs compiled from git (27.0.50), using GTK 3.22.21 (openSUSE Tumbleweed) do not show the selection text. There is a text error in *Message* buffer: Unable to load color "gtk_selection_bg_color" In GNU Emacs 27.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.22.21) of 2017-09-28 built on linux-sjey Repository revision: 551594e951642a043862dabb987facfc0253f7d3 Windowing system distributor 'The X.Org Foundation', version 11.0.11903000 System Description: openSUSE Tumbleweed Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. Unable to load color "gtk_selection_bg_color" Mark set Unable to load color "gtk_selection_bg_color" Mark set [2 times] Unable to load color "gtk_selection_bg_color" Configured using: 'configure --prefix=/home/aplanas/bin/emacs-git' Configured features: XPM JPEG TIFF GIF PNG RSVG SOUND DBUS GSETTINGS NOTIFY GNUTLS LIBXML2 FREETYPE XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 LCMS2 Important settings: value of $LANG: en_US.UTF-8 value of $XMODIFIERS: @im=ibus locale-coding-system: utf-8-unix Major mode: Messages Minor modes in effect: tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t buffer-read-only: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message subr-x puny seq byte-opt gv bytecomp byte-compile cconv cl-loaddefs cl-lib dired dired-loaddefs format-spec rfc822 mml easymenu mml-sec password-cache epa derived epg epg-config gnus-util rmail rmail-loaddefs mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils elec-pair time-date mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 97350 8002) (symbols 48 20191 1) (miscs 40 178 118) (strings 32 28325 1156) (string-bytes 1 747171) (vectors 16 14183) (vector-slots 8 492076 6244) (floats 8 48 141) (intervals 56 216 0) (buffers 992 12)) ^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#28636: 27.0.50; Unable to load color "gtk_selection_bg_color" in 27.0.50 2017-09-28 20:05 bug#28636: 27.0.50; Unable to load color "gtk_selection_bg_color" in 27.0.50 aplanas @ 2017-09-28 20:22 ` Philipp Stephani 2017-09-29 8:34 ` martin rudalics 2017-09-29 20:44 ` Philipp Stephani 0 siblings, 2 replies; 10+ messages in thread From: Philipp Stephani @ 2017-09-28 20:22 UTC (permalink / raw To: aplanas, 28636 [-- Attachment #1: Type: text/plain, Size: 503 bytes --] aplanas <aplanas@gmail.com> schrieb am Do., 28. Sep. 2017 um 22:19 Uhr: > A version of Emacs compiled from git (27.0.50), using GTK 3.22.21 > (openSUSE Tumbleweed) do not show the selection text. > > There is a text error in *Message* buffer: > > Unable to load color "gtk_selection_bg_color" > > Does reverting commit f6818e761eaafe095e07249180dc8f9a329f1473 help? (For context, in newer versions of GTK+ the concept of a background color is deprecated because backgrounds can be arbitrary pictures.) [-- Attachment #2: Type: text/html, Size: 830 bytes --] ^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#28636: 27.0.50; Unable to load color "gtk_selection_bg_color" in 27.0.50 2017-09-28 20:22 ` Philipp Stephani @ 2017-09-29 8:34 ` martin rudalics 2017-09-29 20:42 ` Philipp Stephani 2017-09-29 20:44 ` Philipp Stephani 1 sibling, 1 reply; 10+ messages in thread From: martin rudalics @ 2017-09-29 8:34 UTC (permalink / raw To: Philipp Stephani, aplanas, 28636 >> A version of Emacs compiled from git (27.0.50), using GTK 3.22.21 >> (openSUSE Tumbleweed) do not show the selection text. >> >> There is a text error in *Message* buffer: >> >> Unable to load color "gtk_selection_bg_color" >> >> > Does reverting commit f6818e761eaafe095e07249180dc8f9a329f1473 help? > (For context, in newer versions of GTK+ the concept of a background color > is deprecated because backgrounds can be arbitrary pictures.) Couldn't we just be silent about this then? martin ^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#28636: 27.0.50; Unable to load color "gtk_selection_bg_color" in 27.0.50 2017-09-29 8:34 ` martin rudalics @ 2017-09-29 20:42 ` Philipp Stephani 2017-09-29 21:05 ` Eli Zaretskii 0 siblings, 1 reply; 10+ messages in thread From: Philipp Stephani @ 2017-09-29 20:42 UTC (permalink / raw To: martin rudalics, aplanas, 28636 [-- Attachment #1: Type: text/plain, Size: 913 bytes --] martin rudalics <rudalics@gmx.at> schrieb am Fr., 29. Sep. 2017 um 10:35 Uhr: > >> A version of Emacs compiled from git (27.0.50), using GTK 3.22.21 > >> (openSUSE Tumbleweed) do not show the selection text. > >> > >> There is a text error in *Message* buffer: > >> > >> Unable to load color "gtk_selection_bg_color" > >> > >> > > Does reverting commit f6818e761eaafe095e07249180dc8f9a329f1473 help? > > (For context, in newer versions of GTK+ the concept of a background > color > > is deprecated because backgrounds can be arbitrary pictures.) > > Couldn't we just be silent about this then? > > Do you mean silencing the compiler warning? I guess so, but I think that would be a bit dangerous: at some point the function might get removed entirely, then we'd have to scramble to find a replacement to keep the code compilable, so I'd rather keep the compiler warning until we find a good solution. [-- Attachment #2: Type: text/html, Size: 1312 bytes --] ^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#28636: 27.0.50; Unable to load color "gtk_selection_bg_color" in 27.0.50 2017-09-29 20:42 ` Philipp Stephani @ 2017-09-29 21:05 ` Eli Zaretskii 2017-09-29 21:42 ` Philipp Stephani 0 siblings, 1 reply; 10+ messages in thread From: Eli Zaretskii @ 2017-09-29 21:05 UTC (permalink / raw To: Philipp Stephani; +Cc: aplanas, 28636 > From: Philipp Stephani <p.stephani2@gmail.com> > Date: Fri, 29 Sep 2017 20:42:24 +0000 > > Do you mean silencing the compiler warning? I guess so, but I think that would be a bit dangerous: at some > point the function might get removed entirely, then we'd have to scramble to find a replacement to keep the > code compilable, so I'd rather keep the compiler warning until we find a good solution. Do we have a reason to believe they will be removed any time soon? I've seen deprecated stuff kept for years on end. Or maybe we should ask the GTK developers not to delete them because we need them? ^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#28636: 27.0.50; Unable to load color "gtk_selection_bg_color" in 27.0.50 2017-09-29 21:05 ` Eli Zaretskii @ 2017-09-29 21:42 ` Philipp Stephani 2017-09-29 21:57 ` [PATCH] Work around deprecation of gtk_style_context_get_background_color Philipp Stephani 2017-09-30 6:50 ` bug#28636: 27.0.50; Unable to load color "gtk_selection_bg_color" in 27.0.50 Eli Zaretskii 0 siblings, 2 replies; 10+ messages in thread From: Philipp Stephani @ 2017-09-29 21:42 UTC (permalink / raw To: Eli Zaretskii; +Cc: aplanas, 28636 [-- Attachment #1: Type: text/plain, Size: 1176 bytes --] Eli Zaretskii <eliz@gnu.org> schrieb am Fr., 29. Sep. 2017 um 23:05 Uhr: > > From: Philipp Stephani <p.stephani2@gmail.com> > > Date: Fri, 29 Sep 2017 20:42:24 +0000 > > > > Do you mean silencing the compiler warning? I guess so, but I think that > would be a bit dangerous: at some > > point the function might get removed entirely, then we'd have to > scramble to find a replacement to keep the > > code compilable, so I'd rather keep the compiler warning until we find a > good solution. > > Do we have a reason to believe they will be removed any time soon? > I've seen deprecated stuff kept for years on end. > GTK+ seems to be reasonably serious about this. The function in question here is still present in the source code, but another one that we used to call (gtk_window_parse_geometry) is already gone. > > Or maybe we should ask the GTK developers not to delete them because > we need them? > We could, but I don't think that will have a high probability of success. They would rightly point out that we're doing it wrong. For the function in question, the definition is actually trivial, so we can replace it with the definition for now to buy us some time. [-- Attachment #2: Type: text/html, Size: 1746 bytes --] ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] Work around deprecation of gtk_style_context_get_background_color 2017-09-29 21:42 ` Philipp Stephani @ 2017-09-29 21:57 ` Philipp Stephani 2017-10-03 13:02 ` Philipp Stephani 2017-09-30 6:50 ` bug#28636: 27.0.50; Unable to load color "gtk_selection_bg_color" in 27.0.50 Eli Zaretskii 1 sibling, 1 reply; 10+ messages in thread From: Philipp Stephani @ 2017-09-29 21:57 UTC (permalink / raw To: emacs-devel; +Cc: Philipp Stephani * src/gtkutil.c (xg_check_special_colors): Replace call to gtk_style_context_get_background_color with its definition. --- src/gtkutil.c | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/src/gtkutil.c b/src/gtkutil.c index 9f05524738..015456cd81 100644 --- a/src/gtkutil.c +++ b/src/gtkutil.c @@ -577,11 +577,18 @@ xg_check_special_colors (struct frame *f, if (get_fg) gtk_style_context_get_color (gsty, state, &col); else - /* FIXME: gtk_style_context_get_background_color is deprecated - in GTK+ 3.16. New versions of GTK+ don’t use the concept of - a single background color any more, so we shouldn’t query for - it. */ - gtk_style_context_get_background_color (gsty, state, &col); + { + GdkRGBA *c; + /* FIXME: Retrieving the background color is deprecated in + GTK+ 3.16. New versions of GTK+ don’t use the concept of a + single background color any more, so we shouldn’t query for + it. */ + gtk_style_context_get (gsty, state, + GTK_STYLE_PROPERTY_BACKGROUND_COLOR, &c, + NULL); + col = *c; + gdk_rgba_free (c); + } unsigned short r = col.red * 65535, -- 2.14.2.822.g60be5d43e6-goog ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] Work around deprecation of gtk_style_context_get_background_color 2017-09-29 21:57 ` [PATCH] Work around deprecation of gtk_style_context_get_background_color Philipp Stephani @ 2017-10-03 13:02 ` Philipp Stephani 0 siblings, 0 replies; 10+ messages in thread From: Philipp Stephani @ 2017-10-03 13:02 UTC (permalink / raw To: Philipp Stephani, emacs-devel [-- Attachment #1: Type: text/plain, Size: 1962 bytes --] Philipp Stephani <p.stephani2@gmail.com> schrieb am Fr., 29. Sep. 2017 um 23:58 Uhr: > * src/gtkutil.c (xg_check_special_colors): Replace call to > gtk_style_context_get_background_color with its definition. > --- > src/gtkutil.c | 17 ++++++++++++----- > 1 file changed, 12 insertions(+), 5 deletions(-) > > diff --git a/src/gtkutil.c b/src/gtkutil.c > index 9f05524738..015456cd81 100644 > --- a/src/gtkutil.c > +++ b/src/gtkutil.c > @@ -577,11 +577,18 @@ xg_check_special_colors (struct frame *f, > if (get_fg) > gtk_style_context_get_color (gsty, state, &col); > else > - /* FIXME: gtk_style_context_get_background_color is deprecated > - in GTK+ 3.16. New versions of GTK+ don’t use the concept of > - a single background color any more, so we shouldn’t query for > - it. */ > - gtk_style_context_get_background_color (gsty, state, &col); > + { > + GdkRGBA *c; > + /* FIXME: Retrieving the background color is deprecated in > + GTK+ 3.16. New versions of GTK+ don’t use the concept of a > + single background color any more, so we shouldn’t query for > + it. */ > + gtk_style_context_get (gsty, state, > + GTK_STYLE_PROPERTY_BACKGROUND_COLOR, &c, > + NULL); > + col = *c; > + gdk_rgba_free (c); > + } > > Pushed as 0fff900c18 to emacs-26. -- Google Germany GmbH Erika-Mann-Straße 33 80636 München Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Paul Manicle, Halimah DeLaine Prado If you received this communication by mistake, please don't forward it to anyone else (it may contain confidential or privileged information), please erase all copies of it, including all attachments, and please let the sender know it went to the wrong person. Thanks. [-- Attachment #2: Type: text/html, Size: 2598 bytes --] ^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#28636: 27.0.50; Unable to load color "gtk_selection_bg_color" in 27.0.50 2017-09-29 21:42 ` Philipp Stephani 2017-09-29 21:57 ` [PATCH] Work around deprecation of gtk_style_context_get_background_color Philipp Stephani @ 2017-09-30 6:50 ` Eli Zaretskii 1 sibling, 0 replies; 10+ messages in thread From: Eli Zaretskii @ 2017-09-30 6:50 UTC (permalink / raw To: Philipp Stephani; +Cc: aplanas, 28636 > From: Philipp Stephani <p.stephani2@gmail.com> > Date: Fri, 29 Sep 2017 21:42:28 +0000 > Cc: rudalics@gmx.at, aplanas@gmail.com, 28636@debbugs.gnu.org > > Or maybe we should ask the GTK developers not to delete them because > we need them? > > We could, but I don't think that will have a high probability of success. They would rightly point out that we're > doing it wrong. The point is, our "wrong" way of doing things is likely to stay for a long time the only way a GTK Emacs can be built, so unless there's a possibility to use some other GTK functions to the same effect, it is more probable to lose a GTK Emacs than to have a GTK rewrite of Emacs. Maybe if they understand this, they will reconsider. > For the function in question, the definition is actually trivial, so we can replace it with the definition for now to > buy us some time. That's okay as well. ^ permalink raw reply [flat|nested] 10+ messages in thread
* bug#28636: 27.0.50; Unable to load color "gtk_selection_bg_color" in 27.0.50 2017-09-28 20:22 ` Philipp Stephani 2017-09-29 8:34 ` martin rudalics @ 2017-09-29 20:44 ` Philipp Stephani 1 sibling, 0 replies; 10+ messages in thread From: Philipp Stephani @ 2017-09-29 20:44 UTC (permalink / raw To: aplanas, 28636-done [-- Attachment #1: Type: text/plain, Size: 664 bytes --] Philipp Stephani <p.stephani2@gmail.com> schrieb am Do., 28. Sep. 2017 um 22:22 Uhr: > aplanas <aplanas@gmail.com> schrieb am Do., 28. Sep. 2017 um 22:19 Uhr: > >> A version of Emacs compiled from git (27.0.50), using GTK 3.22.21 >> (openSUSE Tumbleweed) do not show the selection text. >> >> There is a text error in *Message* buffer: >> >> Unable to load color "gtk_selection_bg_color" >> >> > Does reverting commit f6818e761eaafe095e07249180dc8f9a329f1473 help? > (For context, in newer versions of GTK+ the concept of a background color > is deprecated because backgrounds can be arbitrary pictures.) > I've pushed the revert to master (commit 5406be4db6). [-- Attachment #2: Type: text/html, Size: 1298 bytes --] ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2017-10-03 13:02 UTC | newest] Thread overview: 10+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2017-09-28 20:05 bug#28636: 27.0.50; Unable to load color "gtk_selection_bg_color" in 27.0.50 aplanas 2017-09-28 20:22 ` Philipp Stephani 2017-09-29 8:34 ` martin rudalics 2017-09-29 20:42 ` Philipp Stephani 2017-09-29 21:05 ` Eli Zaretskii 2017-09-29 21:42 ` Philipp Stephani 2017-09-29 21:57 ` [PATCH] Work around deprecation of gtk_style_context_get_background_color Philipp Stephani 2017-10-03 13:02 ` Philipp Stephani 2017-09-30 6:50 ` bug#28636: 27.0.50; Unable to load color "gtk_selection_bg_color" in 27.0.50 Eli Zaretskii 2017-09-29 20:44 ` Philipp Stephani
Code repositories for project(s) associated with this external index https://git.savannah.gnu.org/cgit/emacs.git https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.