From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#27653: Patch for bug#27653: 25.2; ses.el text cell justification Date: Thu, 05 Oct 2017 13:09:31 +0300 Message-ID: <834lrdykh0.fsf@gnu.org> References: <20170711140222.GA9802@miroslavurbanek.com> <83y3pxxkff.fsf@gnu.org> <87tvzkf47p.fsf_-_@runbox.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1507198223 8739 195.159.176.226 (5 Oct 2017 10:10:23 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 5 Oct 2017 10:10:23 +0000 (UTC) Cc: 27653@debbugs.gnu.org, mu@miroslavurbanek.com To: Gemini Lasswell , Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Oct 05 12:10:17 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e036d-0001OU-UY for geb-bug-gnu-emacs@m.gmane.org; Thu, 05 Oct 2017 12:10:16 +0200 Original-Received: from localhost ([::1]:38858 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e036j-0002O5-Rx for geb-bug-gnu-emacs@m.gmane.org; Thu, 05 Oct 2017 06:10:21 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42668) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e036W-0002HV-M5 for bug-gnu-emacs@gnu.org; Thu, 05 Oct 2017 06:10:16 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e036Q-0005w2-Lg for bug-gnu-emacs@gnu.org; Thu, 05 Oct 2017 06:10:08 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:41081) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e036Q-0005vx-Hk for bug-gnu-emacs@gnu.org; Thu, 05 Oct 2017 06:10:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e036Q-0000sm-CD for bug-gnu-emacs@gnu.org; Thu, 05 Oct 2017 06:10:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 Oct 2017 10:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27653 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 27653-submit@debbugs.gnu.org id=B27653.15071981943365 (code B ref 27653); Thu, 05 Oct 2017 10:10:02 +0000 Original-Received: (at 27653) by debbugs.gnu.org; 5 Oct 2017 10:09:54 +0000 Original-Received: from localhost ([127.0.0.1]:49761 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e036H-0000sC-UV for submit@debbugs.gnu.org; Thu, 05 Oct 2017 06:09:54 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:51608) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e036G-0000s0-CR for 27653@debbugs.gnu.org; Thu, 05 Oct 2017 06:09:52 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e0367-0005cW-C4 for 27653@debbugs.gnu.org; Thu, 05 Oct 2017 06:09:47 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:46256) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e0367-0005cO-83; Thu, 05 Oct 2017 06:09:43 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2858 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1e0366-0007W6-FS; Thu, 05 Oct 2017 06:09:42 -0400 In-reply-to: <87tvzkf47p.fsf_-_@runbox.com> (message from Gemini Lasswell on Sat, 30 Sep 2017 11:11:40 -0700) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:137951 Archived-At: > From: Gemini Lasswell > Cc: Miroslav Urbanek , 27653@debbugs.gnu.org > Date: Sat, 30 Sep 2017 11:11:40 -0700 > > Eli Zaretskii writes: > > > Could you please provide a minimal recipe, starting from "emacs -Q", > > that could be used to reproduce the problem? > > >From emacs -Q: > > C-x C-f abc.ses RET > " abc RET > > Result: The text is left justified. > > I looked through those and found a change in df5703a00d which looked > like a likely suspect. Reverting it fixes the bug. It looks to me like > the only thing the change affects is justification of text cells, but > someone who is familiar with ses.el should have a look at it. Stefan, the change in ses-print-cell that causes this bug is not mentioned in the log message of df5703a00d. Can you tell why you made that change? > >From da3b761e2e5fb10f1512befb7399a198e2419faa Mon Sep 17 00:00:00 2001 > From: Gemini Lasswell > Date: Sat, 30 Sep 2017 10:31:25 -0700 > Subject: [PATCH] * lisp/ses.el (ses-print-cell): Fix alignment of text cells > (bug#27653) > > --- > lisp/ses.el | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/lisp/ses.el b/lisp/ses.el > index 9221476e7a..4c19c70c5d 100644 > --- a/lisp/ses.el > +++ b/lisp/ses.el > @@ -1254,8 +1254,7 @@ ses-print-cell > ((< len width) > ;; Fill field to length with spaces. > (setq len (make-string (- width len) ?\s) > - text (if (or (stringp value) > - (eq ses-call-printer-return t)) > + text (if (eq ses-call-printer-return t) > (concat text len) > (concat len text)))) > ((> len width) > -- > 2.14.1 >