all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Noam Postavsky <npostavs@users.sourceforge.net>
Cc: 28631@debbugs.gnu.org, tino.calancha@gmail.com
Subject: bug#28631: 25.3.50; Deactivate mark with Ctrl-g mess up the primary-selection
Date: Sat, 14 Oct 2017 09:56:20 +0300	[thread overview]
Message-ID: <834lr2jjzf.fsf@gnu.org> (raw)
In-Reply-To: <87shema39u.fsf@users.sourceforge.net> (message from Noam Postavsky on Fri, 13 Oct 2017 22:09:49 -0400)

> From: Noam Postavsky <npostavs@users.sourceforge.net>
> Cc: Eli Zaretskii <eliz@gnu.org>,  28631@debbugs.gnu.org
> Date: Fri, 13 Oct 2017 22:09:49 -0400
> 
> >> That patch only has affect during winner-undo, no?
> > I think so.
> 
> Actually, I thought about it a bit more, and realized it could also
> affect things like post-command hooks that are run after winner-undo.
> 
> >> Maybe only the (setf (winner-active-region) (cdr entry)) part should be
> >> skipped?
> > We need to ban
> > (set-mark (car entry))
> > as well, because it updates the primary selection.
> 
> Ah, okay.
> 
> > I assume if someone have set select-enable-primary, then she
> > probably doesn't want winner-undo to change her selection.
> 
> Seems reasonable.

Please push to emacs-26 in a few days, if no comments or objections
surface.

Thanks.





  reply	other threads:[~2017-10-14  6:56 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-28  8:02 bug#28631: 25.3.50; Deactivate mark with Ctrl-g mess up the primary-selection Tino Calancha
2017-10-12  0:52 ` Tino Calancha
2017-10-12  2:06 ` Noam Postavsky
2017-10-12  2:53   ` Tino Calancha
2017-10-13  0:46     ` Noam Postavsky
2017-10-13  1:54       ` Tino Calancha
2017-10-13  6:48       ` Eli Zaretskii
2017-10-13  8:06         ` Tino Calancha
2017-10-13 13:32           ` Noam Postavsky
2017-10-14  1:42             ` Tino Calancha
2017-10-14  2:09               ` Noam Postavsky
2017-10-14  6:56                 ` Eli Zaretskii [this message]
2017-10-17  7:25                   ` Tino Calancha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=834lr2jjzf.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=28631@debbugs.gnu.org \
    --cc=npostavs@users.sourceforge.net \
    --cc=tino.calancha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.