From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#29066: 26.0.90; crash in gc involving buffer local symbols Date: Tue, 31 Oct 2017 20:59:11 +0200 Message-ID: <834lqfta80.fsf@gnu.org> References: <83a808tlqp.fsf@gnu.org> <838tfst27n.fsf@gnu.org> <87efpjzv2p.fsf@linux-m68k.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1509476483 23230 195.159.176.226 (31 Oct 2017 19:01:23 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 31 Oct 2017 19:01:23 +0000 (UTC) Cc: 29066@debbugs.gnu.org, vgatien-baron@janestreet.com, mshinwell@janestreet.com To: Andreas Schwab Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Oct 31 20:01:09 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e9bmb-0004T2-Du for geb-bug-gnu-emacs@m.gmane.org; Tue, 31 Oct 2017 20:01:05 +0100 Original-Received: from localhost ([::1]:46974 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e9bmi-0007S7-K6 for geb-bug-gnu-emacs@m.gmane.org; Tue, 31 Oct 2017 15:01:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36780) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e9bmc-0007Qy-16 for bug-gnu-emacs@gnu.org; Tue, 31 Oct 2017 15:01:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e9bmZ-0005h1-0R for bug-gnu-emacs@gnu.org; Tue, 31 Oct 2017 15:01:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:35868) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e9bmY-0005gV-Si for bug-gnu-emacs@gnu.org; Tue, 31 Oct 2017 15:01:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e9bmY-0003sU-Hs for bug-gnu-emacs@gnu.org; Tue, 31 Oct 2017 15:01:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 31 Oct 2017 19:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29066 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 29066-submit@debbugs.gnu.org id=B29066.150947640214759 (code B ref 29066); Tue, 31 Oct 2017 19:01:02 +0000 Original-Received: (at 29066) by debbugs.gnu.org; 31 Oct 2017 19:00:02 +0000 Original-Received: from localhost ([127.0.0.1]:44549 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e9blZ-0003po-9d for submit@debbugs.gnu.org; Tue, 31 Oct 2017 15:00:02 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:45552) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e9blX-0003pD-Bv for 29066@debbugs.gnu.org; Tue, 31 Oct 2017 14:59:59 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e9blP-0005Bb-1M for 29066@debbugs.gnu.org; Tue, 31 Oct 2017 14:59:54 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:47640) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e9bky-0004vT-F9; Tue, 31 Oct 2017 14:59:24 -0400 Original-Received: from [176.228.60.248] (port=1402 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1e9bkx-0001eu-SJ; Tue, 31 Oct 2017 14:59:24 -0400 In-reply-to: <87efpjzv2p.fsf@linux-m68k.org> (message from Andreas Schwab on Tue, 31 Oct 2017 07:32:14 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:139273 Archived-At: > From: Andreas Schwab > Cc: Valentin Gatien-Baron , 29066@debbugs.gnu.org, mshinwell@janestreet.com > Date: Tue, 31 Oct 2017 07:32:14 +0100 > > On Okt 31 2017, Eli Zaretskii wrote: > > >> if (!sym->s.gcmarkbit) > >> { > >> - if (sym->s.redirect == SYMBOL_LOCALIZED) > >> + if (sym->s.redirect == SYMBOL_LOCALIZED) { > >> xfree (SYMBOL_BLV (&sym->s)); > >> + sym->s.val.blv = NULL; > >> + } > > > > That was my first attempt, but various macros like SYMBOL_BLV and > > SET_SYMBOL_BLV insist on val.blv being non-NULL. > > SET_SYMBOL_BLV doesn't. Maybe I'm blind, or misunderstand what you mean, but if the intent was to do this: SET_SYMBOL_BLV (&sym->s, NULL); then it does: INLINE void SET_SYMBOL_BLV (struct Lisp_Symbol *sym, struct Lisp_Buffer_Local_Value *v) { eassume (sym->redirect == SYMBOL_LOCALIZED && v); <<<<<<<<<<<<<<<< sym->val.blv = v; } > And calling SYMBOL_BLV with a freed symbol is a bug anyway. It isn't freed, it's on the symbol_free_list. Only its buffer-local value is freed.