From: Eli Zaretskii <eliz@gnu.org>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: 29066@debbugs.gnu.org, vgatien-baron@janestreet.com,
mshinwell@janestreet.com
Subject: bug#29066: 26.0.90; crash in gc involving buffer local symbols
Date: Tue, 31 Oct 2017 20:59:11 +0200 [thread overview]
Message-ID: <834lqfta80.fsf@gnu.org> (raw)
In-Reply-To: <87efpjzv2p.fsf@linux-m68k.org> (message from Andreas Schwab on Tue, 31 Oct 2017 07:32:14 +0100)
> From: Andreas Schwab <schwab@linux-m68k.org>
> Cc: Valentin Gatien-Baron <vgatien-baron@janestreet.com>, 29066@debbugs.gnu.org, mshinwell@janestreet.com
> Date: Tue, 31 Oct 2017 07:32:14 +0100
>
> On Okt 31 2017, Eli Zaretskii <eliz@gnu.org> wrote:
>
> >> if (!sym->s.gcmarkbit)
> >> {
> >> - if (sym->s.redirect == SYMBOL_LOCALIZED)
> >> + if (sym->s.redirect == SYMBOL_LOCALIZED) {
> >> xfree (SYMBOL_BLV (&sym->s));
> >> + sym->s.val.blv = NULL;
> >> + }
> >
> > That was my first attempt, but various macros like SYMBOL_BLV and
> > SET_SYMBOL_BLV insist on val.blv being non-NULL.
>
> SET_SYMBOL_BLV doesn't.
Maybe I'm blind, or misunderstand what you mean, but if the intent was
to do this:
SET_SYMBOL_BLV (&sym->s, NULL);
then it does:
INLINE void
SET_SYMBOL_BLV (struct Lisp_Symbol *sym, struct Lisp_Buffer_Local_Value *v)
{
eassume (sym->redirect == SYMBOL_LOCALIZED && v); <<<<<<<<<<<<<<<<
sym->val.blv = v;
}
> And calling SYMBOL_BLV with a freed symbol is a bug anyway.
It isn't freed, it's on the symbol_free_list. Only its buffer-local
value is freed.
next prev parent reply other threads:[~2017-10-31 18:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-30 14:36 bug#29066: 26.0.90; crash in gc involving buffer local symbols Valentin Gatien-Baron
2017-10-30 20:38 ` Eli Zaretskii
2017-10-30 22:04 ` Valentin Gatien-Baron
2017-10-31 3:39 ` Eli Zaretskii
2017-10-31 6:32 ` Andreas Schwab
2017-10-31 14:52 ` Valentin Gatien-Baron
2017-10-31 19:10 ` Eli Zaretskii
2017-10-31 19:58 ` Valentin Gatien-Baron
2017-10-31 20:09 ` Eli Zaretskii
2017-10-31 20:13 ` Valentin Gatien-Baron
2017-10-31 18:59 ` Eli Zaretskii [this message]
2017-10-31 20:23 ` Andreas Schwab
2017-10-31 20:34 ` Eli Zaretskii
2017-10-31 21:03 ` Andreas Schwab
2017-10-31 21:08 ` Eli Zaretskii
2017-10-31 22:00 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=834lqfta80.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=29066@debbugs.gnu.org \
--cc=mshinwell@janestreet.com \
--cc=schwab@linux-m68k.org \
--cc=vgatien-baron@janestreet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.