From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#31656: 26.1; `fill-paragraph' malformats in emacs-lisp-mode Date: Sat, 02 Jun 2018 09:41:47 +0300 Message-ID: <834lilg05w.fsf@gnu.org> References: <83sh66g8wb.fsf@gnu.org> <87bmcuc0bo.fsf@gmail.com> <83muwefziz.fsf@gnu.org> <878t7yarlq.fsf@gmail.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1527921604 5754 195.159.176.226 (2 Jun 2018 06:40:04 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 2 Jun 2018 06:40:04 +0000 (UTC) Cc: 31656@debbugs.gnu.org, stefan@automata.se To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jun 02 08:40:00 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fP0Cl-0001Lz-Gp for geb-bug-gnu-emacs@m.gmane.org; Sat, 02 Jun 2018 08:39:59 +0200 Original-Received: from localhost ([::1]:58509 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fP0Es-0006AH-JW for geb-bug-gnu-emacs@m.gmane.org; Sat, 02 Jun 2018 02:42:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46049) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fP0Ek-0006A3-So for bug-gnu-emacs@gnu.org; Sat, 02 Jun 2018 02:42:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fP0Ej-00045m-Vw for bug-gnu-emacs@gnu.org; Sat, 02 Jun 2018 02:42:02 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:50411) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fP0Ej-000452-SF for bug-gnu-emacs@gnu.org; Sat, 02 Jun 2018 02:42:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fP0Ej-0001Lp-LC for bug-gnu-emacs@gnu.org; Sat, 02 Jun 2018 02:42:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 02 Jun 2018 06:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31656 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 31656-submit@debbugs.gnu.org id=B31656.15279217195185 (code B ref 31656); Sat, 02 Jun 2018 06:42:01 +0000 Original-Received: (at 31656) by debbugs.gnu.org; 2 Jun 2018 06:41:59 +0000 Original-Received: from localhost ([127.0.0.1]:58308 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fP0Eh-0001LZ-1F for submit@debbugs.gnu.org; Sat, 02 Jun 2018 02:41:59 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:55037) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fP0Ef-0001LM-QS for 31656@debbugs.gnu.org; Sat, 02 Jun 2018 02:41:58 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fP0EZ-0003Ik-Bn for 31656@debbugs.gnu.org; Sat, 02 Jun 2018 02:41:52 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:41591) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fP0EU-0002wH-5t; Sat, 02 Jun 2018 02:41:46 -0400 Original-Received: from [176.228.60.248] (port=1537 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fP0ET-00008m-Gq; Sat, 02 Jun 2018 02:41:45 -0400 In-reply-to: <878t7yarlq.fsf@gmail.com> (message from Noam Postavsky on Fri, 01 Jun 2018 21:45:37 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:146840 Archived-At: > From: Noam Postavsky > Cc: 31656@debbugs.gnu.org, stefan@automata.se > Date: Fri, 01 Jun 2018 21:45:37 -0400 > > --- i/lisp/emacs-lisp/lisp-mode.el > +++ w/lisp/emacs-lisp/lisp-mode.el > @@ -1314,6 +1314,7 @@ lisp-fill-paragraph > ;; > ;; The `fill-column' is temporarily bound to > ;; `emacs-lisp-docstring-fill-column' if that value is an integer. > + (when (nth 3 (syntax-ppss)) ; Only fill inside strings. > (let ((paragraph-start > (concat paragraph-start > "\\|\\s-*\\([(;\"]\\|\\s-:\\|`(\\|#'(\\)")) > @@ -1323,7 +1324,7 @@ lisp-fill-paragraph > (derived-mode-p 'emacs-lisp-mode)) > emacs-lisp-docstring-fill-column > fill-column))) > - (fill-paragraph justify)) > + (fill-paragraph justify))) > ;; Never return nil. > t)) > > > I think this covers the scenario in the OP. Are there no use cases where we would want M-q outside of syntactic strings?