From: Eli Zaretskii <eliz@gnu.org>
To: Noam Postavsky <npostavs@gmail.com>
Cc: 32051@debbugs.gnu.org, Dan.Harms@xrtrading.com
Subject: bug#32051: 26.1; grep-regexp-alist on windows
Date: Fri, 06 Jul 2018 11:51:56 +0300 [thread overview]
Message-ID: <834lhcn3v7.fsf@gnu.org> (raw)
In-Reply-To: <CAM-tV-_r937hzMYep-MuisBZcsBSopgxuyPDFxWgO6qF-wDp3w@mail.gmail.com> (message from Noam Postavsky on Wed, 4 Jul 2018 15:57:53 -0400)
> From: Noam Postavsky <npostavs@gmail.com>
> Date: Wed, 4 Jul 2018 15:57:53 -0400
> Cc: Dan Harms <Dan.Harms@xrtrading.com>, 32051@debbugs.gnu.org
>
> Looking at the grep-regexp-alist, it is the case that a filename with
> a colon will not be matched when grep doesn't support --null. In the
> case where grep does support --null, the NUL byte is displayed like a
> colon, so the difference might not leap out at you.
Right, thanks.
> I think the patch below would fix it:
Looks reasonable. Can we have a test for this use case, so that we
never again regress like that?
next prev parent reply other threads:[~2018-07-06 8:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-04 12:14 bug#32051: 26.1; grep-regexp-alist on windows Dan Harms
2018-07-04 16:26 ` Eli Zaretskii
2018-07-04 19:57 ` Noam Postavsky
2018-07-06 8:51 ` Eli Zaretskii [this message]
2018-07-09 21:08 ` Noam Postavsky
2018-07-10 15:57 ` Eli Zaretskii
2018-07-13 1:51 ` Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=834lhcn3v7.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=32051@debbugs.gnu.org \
--cc=Dan.Harms@xrtrading.com \
--cc=npostavs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.