From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#32462: 26.1; Can `count-lines' be rewritten to use the newline cache? Date: Fri, 17 Aug 2018 17:40:35 +0300 Message-ID: <834lftgios.fsf@gnu.org> References: NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1534518891 11939 195.159.176.226 (17 Aug 2018 15:14:51 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 17 Aug 2018 15:14:51 +0000 (UTC) Cc: 32462@debbugs.gnu.org To: Phil Sainty Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Aug 17 17:14:47 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fqgSc-00032i-M3 for geb-bug-gnu-emacs@m.gmane.org; Fri, 17 Aug 2018 17:14:46 +0200 Original-Received: from localhost ([::1]:34688 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fqgUj-0000e7-3y for geb-bug-gnu-emacs@m.gmane.org; Fri, 17 Aug 2018 11:16:57 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36188) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fqfvz-0000FC-0t for bug-gnu-emacs@gnu.org; Fri, 17 Aug 2018 10:41:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fqfvy-0006ZM-6w for bug-gnu-emacs@gnu.org; Fri, 17 Aug 2018 10:41:02 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:48665) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fqfvy-0006ZD-01 for bug-gnu-emacs@gnu.org; Fri, 17 Aug 2018 10:41:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fqfvx-0002sW-TV for bug-gnu-emacs@gnu.org; Fri, 17 Aug 2018 10:41:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 17 Aug 2018 14:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32462 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 32462-submit@debbugs.gnu.org id=B32462.153451685811047 (code B ref 32462); Fri, 17 Aug 2018 14:41:01 +0000 Original-Received: (at 32462) by debbugs.gnu.org; 17 Aug 2018 14:40:58 +0000 Original-Received: from localhost ([127.0.0.1]:53683 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fqfvu-0002s7-KZ for submit@debbugs.gnu.org; Fri, 17 Aug 2018 10:40:58 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:43345) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fqfvs-0002rs-P7 for 32462@debbugs.gnu.org; Fri, 17 Aug 2018 10:40:57 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fqfvi-0006KS-2x for 32462@debbugs.gnu.org; Fri, 17 Aug 2018 10:40:50 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:40823) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fqfvh-0006KA-Ly; Fri, 17 Aug 2018 10:40:45 -0400 Original-Received: from [176.228.60.248] (port=3361 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fqfvg-0006QT-Un; Fri, 17 Aug 2018 10:40:45 -0400 In-reply-to: (message from Phil Sainty on Fri, 17 Aug 2018 13:01:38 +1200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:149559 Archived-At: > Date: Fri, 17 Aug 2018 13:01:38 +1200 > From: Phil Sainty > > `count-lines' uses a regexp search to find all the newlines (and/or > carriage returns It uses regexp search only when selective-display is in effect, which means almost never. Otherwise, it uses forward-line, which uses scan_newline_from_point, which already uses the newline cache (unless the cache is disabled). (And based on my experience, the newline cache doesn't actually speed up things all that much, except in buffers with unusually long lines.)