Calling message with a single arg (was: [Emacs-diffs] emacs-26 5f39260: * lisp/emacs-lisp/map-ynp.el (map-y-or-n-p): Pass format to message)

Calling message with a single arg (was: [Emacs-diffs] emacs-26 5f39260: * lisp/emacs-lisp/map-ynp.el (map-y-or-n-p): Pass format to message)

[Stefan Monnier]

> -      (message (or msg "")))
> +      (if msg
> +          (message "%s" msg)
> +        (message "")))

I wish we'd just change `message` so that (message STR) is treated as
(message "%s" STR).  While it might theoretically introduce some
breakage at places that double % signs before calling `message` (tho
those places are better served by (message "%s" STR) so there should be
precious few sufferers), I suspect that it will fix more places that
naively call (message STR) without realizing that STR might contain %
chars that are treated as formatting codes.


        Stefan

Re: Calling message with a single arg (was: [Emacs-diffs] emacs-26 5f39260: * lisp/emacs-lisp/map-ynp.el (map-y-or-n-p): Pass format to message)

[Eli Zaretskii]

> From: Stefan Monnier <monnier@IRO.UMontreal.CA>
> Date: Tue, 27 Nov 2018 13:15:14 -0500
> 
> I wish we'd just change `message` so that (message STR) is treated as
> (message "%s" STR).

Didn't we have enough trouble from similar changes in related
departments lately?  I say let's rest for a while before the next
revolution, shall we?