From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#33749: 26.1; input-decode-map to empty vector should preserve echo area Date: Wed, 26 Dec 2018 05:32:47 +0200 Message-ID: <834lb17yjk.fsf@gnu.org> References: <835zvh8k7x.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1545795131 31051 195.159.176.226 (26 Dec 2018 03:32:11 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 26 Dec 2018 03:32:11 +0000 (UTC) Cc: yurivkhan@gmail.com, 33749@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Dec 26 04:32:06 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gbzvS-0007wi-2Y for geb-bug-gnu-emacs@m.gmane.org; Wed, 26 Dec 2018 04:32:06 +0100 Original-Received: from localhost ([127.0.0.1]:44250 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gbzxY-0003cm-VQ for geb-bug-gnu-emacs@m.gmane.org; Tue, 25 Dec 2018 22:34:16 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:33281) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gbzxP-0003cV-Cf for bug-gnu-emacs@gnu.org; Tue, 25 Dec 2018 22:34:12 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gbzxK-0000Xf-H2 for bug-gnu-emacs@gnu.org; Tue, 25 Dec 2018 22:34:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:51900) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gbzxK-0000XU-Dz for bug-gnu-emacs@gnu.org; Tue, 25 Dec 2018 22:34:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gbzxK-0004ot-8v for bug-gnu-emacs@gnu.org; Tue, 25 Dec 2018 22:34:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 26 Dec 2018 03:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33749 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 33749-submit@debbugs.gnu.org id=B33749.154579519218340 (code B ref 33749); Wed, 26 Dec 2018 03:34:02 +0000 Original-Received: (at 33749) by debbugs.gnu.org; 26 Dec 2018 03:33:12 +0000 Original-Received: from localhost ([127.0.0.1]:36548 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gbzwR-0004lf-T8 for submit@debbugs.gnu.org; Tue, 25 Dec 2018 22:33:12 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:41236) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gbzwL-0004l3-Vq for 33749@debbugs.gnu.org; Tue, 25 Dec 2018 22:33:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gbzwB-0007sv-UV for 33749@debbugs.gnu.org; Tue, 25 Dec 2018 22:32:56 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:60377) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gbzwB-0007sp-Rc; Tue, 25 Dec 2018 22:32:51 -0500 Original-Received: from [176.228.60.248] (port=4050 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gbzwB-0003sn-GE; Tue, 25 Dec 2018 22:32:51 -0500 In-reply-to: (message from Stefan Monnier on Tue, 25 Dec 2018 15:07:50 -0500) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:153860 Archived-At: > From: Stefan Monnier > Cc: yurivkhan@gmail.com, 33749@debbugs.gnu.org > Date: Tue, 25 Dec 2018 15:07:50 -0500 > > >> I think The Right Thing to do is likely to move this code to > >> read_key_sequence, more specifically, move it to the point where we > >> *know* we really do have an event. > >> IOW, I think the patch below might be a better option (where we test > >> `indec.start > 0` to make sure some *decoded* event was read). > > Where in that patch is the variable that I asked for, which would > > trigger this special behavior? > > Nowhere ;-) > > Mostly because I don't know where we could set this variable (other > than globally). > > If you want me to add a global var to control whether we use the old or > the new behavior, I'm fine with that. Yes, please. > Note also that the current patch is likely not quite right yet anyway: > I mostly posted it for discussion. E.g. I think where I put it > currently, it fails to be run for single-key commands. Yes, I understand.