From: Eli Zaretskii <eliz@gnu.org>
To: Philipp Stephani <p.stephani2@gmail.com>
Cc: phst@google.com, emacs-devel@gnu.org
Subject: Re: [PATCH] Ignore pending_signals when checking for quits.
Date: Sun, 10 Feb 2019 21:40:43 +0200 [thread overview]
Message-ID: <834l9bmnyc.fsf@gnu.org> (raw)
In-Reply-To: <CAArVCkQVL-ZJE=X2vrUQ180btz8kKCNw4cWeWiu+ZOUwg8y9AQ@mail.gmail.com> (message from Philipp Stephani on Sun, 10 Feb 2019 19:49:39 +0100)
> From: Philipp Stephani <p.stephani2@gmail.com>
> Date: Sun, 10 Feb 2019 19:49:39 +0100
> Cc: Emacs developers <emacs-devel@gnu.org>, Philipp Stephani <phst@google.com>
>
> > Bother. I see your point regarding the return value when just
> > pending_signals is set, but disregarding pending_signals doesn't sound
> > TRT to me, either. It means various Emacs features based on input
> > detection won't work while the module code runs, even if the module
> > tries to be nice and does call module_should_quit. For example,
> > while-no-input and atimers won't work, and Emacs will generally be
> > much less responsive to user input.
> >
> > So maybe we should indeed return true only if QUITP says so, but we
> > should also call process_pending_signals from module_should_quit, when
> > pending_signals is non-zero?
>
> Wouldn't that mean that Emacs could do something (e.g. process
> events)? That wouldn't match the naming and intention of should_quit:
> By its name, it should only query information and not change any
> state.
If the only problem is the name, we could change the name. Or we
could introduce a new function. But let's first agree about the
substance: a well-behaving module should from time to time call
process_pending_signals. Agreed?
next prev parent reply other threads:[~2019-02-10 19:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-02 21:22 [PATCH] Ignore pending_signals when checking for quits Philipp Stephani
2019-01-03 14:03 ` Eli Zaretskii
2019-02-10 18:49 ` Philipp Stephani
2019-02-10 19:40 ` Eli Zaretskii [this message]
2019-02-10 19:46 ` Philipp Stephani
2019-02-10 20:15 ` Eli Zaretskii
2019-02-11 20:17 ` Philipp Stephani
2019-02-13 15:28 ` Eli Zaretskii
2019-02-24 21:51 ` Philipp Stephani
2019-04-19 19:06 ` Philipp Stephani
2019-04-19 20:15 ` Eli Zaretskii
2019-04-28 18:19 ` Philipp Stephani
2019-04-28 18:42 ` Eli Zaretskii
2019-08-07 16:22 ` Philipp Stephani
2019-01-03 14:09 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=834l9bmnyc.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=p.stephani2@gmail.com \
--cc=phst@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.