From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Fill column indicator functionality Date: Tue, 12 Mar 2019 18:19:34 +0200 Message-ID: <834l883w15.fsf@gnu.org> References: <87sgwvco1l.fsf@Ergus.i-did-not-set--mail-host-address--so-tickle-me> <83r2cel3qf.fsf@gnu.org> <20190211165636.ch5x4wb2ibdt2dzy@Ergus> <83ef8el03u.fsf@gnu.org> <20190308185744.a4vnfoab5wdvqyny@Ergus> <83y35p871q.fsf@gnu.org> <20190309132207.w2ho3j6p5on6fyzw@Ergus> <838sxo87gc.fsf@gnu.org> <20190311104814.kp2nv6arv47hcykz@Ergus> <83y35l4ee0.fsf@gnu.org> <20190312152928.73o4b5fk4paz7wm5@Ergus> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="57234"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org To: Ergus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Mar 12 18:07:14 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h3krx-000Ef2-10 for ged-emacs-devel@m.gmane.org; Tue, 12 Mar 2019 18:07:13 +0100 Original-Received: from localhost ([127.0.0.1]:56031 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h3krv-0004p9-5y for ged-emacs-devel@m.gmane.org; Tue, 12 Mar 2019 13:07:11 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:36784) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h3k7w-0006EK-O6 for emacs-devel@gnu.org; Tue, 12 Mar 2019 12:19:41 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:57837) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h3k7v-0004AX-IQ; Tue, 12 Mar 2019 12:19:40 -0400 Original-Received: from [176.228.60.248] (port=2505 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1h3k7u-0007C3-TB; Tue, 12 Mar 2019 12:19:39 -0400 In-reply-to: <20190312152928.73o4b5fk4paz7wm5@Ergus> (message from Ergus on Tue, 12 Mar 2019 16:29:30 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:234110 Archived-At: > Date: Tue, 12 Mar 2019 16:29:30 +0100 > From: Ergus > Cc: emacs-devel@gnu.org > > Sorry for being so annoying. Nothing to be sorry about. > I tried: > if (!row->reversed_p) > { > while (glyph >= start > && (glyph->type == CHAR_GLYPH > || glyph->type == STRETCH_GLYPH) > && NILP (glyph->object)) > --glyph; > } > > But it didn't work. The behavior is the same: the whitespace is > highlighted only when the line is crossed. I guess at this point I'd need to see the code to help you more. Alternatively, you could step with a debugger through the code of highlight_trailing_whitespace and see why it isn't working. It should be something simple, I think. > The other corner case I have is because in graphical mode the space for > the dot is always reserved, so when the last character in the line is > just before the line, the line is not drawn for that line. Sorry, I don't understand: what is "the dot" in this context, and what do you mean by "just before the line"? There are too many "lines" in this sentence, so I'm confused. > In text mode I fixed this changing a while for a do while, but in > graphical mode the approach is different. Well, it sounds like again seeing the code should explain what I don't understand.