From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#35418: [PATCH] Don't poll auto-revert files that use notification Date: Mon, 29 Apr 2019 19:23:53 +0300 Message-ID: <834l6gu6ee.fsf@gnu.org> References: <83sgu71b91.fsf@gnu.org> <74CB5185-5DA1-4786-BD9C-9EEB3D43B3C1@acm.org> <83o94uz9h2.fsf@gnu.org> <875zqzssql.fsf@gmx.de> <83d0l7v193.fsf@gnu.org> <86EFE367-90FF-4786-BC91-FC28FAF38A4E@acm.org> <877ebdqmbj.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="118405"; mail-complaints-to="usenet@blaine.gmane.org" Cc: michael.albinus@gmx.de, 35418@debbugs.gnu.org To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Apr 29 18:25:16 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hL95d-000UWR-M3 for geb-bug-gnu-emacs@m.gmane.org; Mon, 29 Apr 2019 18:25:13 +0200 Original-Received: from localhost ([127.0.0.1]:60232 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hL95c-0000XO-IM for geb-bug-gnu-emacs@m.gmane.org; Mon, 29 Apr 2019 12:25:12 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:55687) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hL95T-0000Wr-LX for bug-gnu-emacs@gnu.org; Mon, 29 Apr 2019 12:25:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hL95S-00065Q-N3 for bug-gnu-emacs@gnu.org; Mon, 29 Apr 2019 12:25:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54263) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hL95S-000657-2Q for bug-gnu-emacs@gnu.org; Mon, 29 Apr 2019 12:25:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hL95R-0007Rm-Sp for bug-gnu-emacs@gnu.org; Mon, 29 Apr 2019 12:25:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 29 Apr 2019 16:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35418-submit@debbugs.gnu.org id=B35418.155655505028537 (code B ref 35418); Mon, 29 Apr 2019 16:25:01 +0000 Original-Received: (at 35418) by debbugs.gnu.org; 29 Apr 2019 16:24:10 +0000 Original-Received: from localhost ([127.0.0.1]:39573 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hL94c-0007QC-7L for submit@debbugs.gnu.org; Mon, 29 Apr 2019 12:24:10 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:41080) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hL94b-0007Pu-3s for 35418@debbugs.gnu.org; Mon, 29 Apr 2019 12:24:09 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:58579) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hL94V-0005nI-Mn; Mon, 29 Apr 2019 12:24:03 -0400 Original-Received: from [176.228.60.248] (port=1820 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hL94U-0002aS-P2; Mon, 29 Apr 2019 12:24:03 -0400 In-reply-to: (message from Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= on Mon, 29 Apr 2019 13:06:50 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:158435 Archived-At: > From: Mattias Engdegård > Date: Mon, 29 Apr 2019 13:06:50 +0200 > Cc: Eli Zaretskii , 35418@debbugs.gnu.org > > By the way, the organisation of this part of the manual could be improved -- don't you agree? Could be. > There is a section called Reverting, which starts about `revert-buffer' but then goes on to talk about the auto-revert, global-auto-revert and auto-revert-tail modes and details about the mechanisms behind them: polling, intervals, notification. > > Then there is a (sibling) section called Autorevert, which despite its name only talks about auto-reverting non-file buffers. You say "section" but the names you cite are node names, not section names. The latter are slightly more descriptive. > This can be reorganised in various ways. We could move all autorevert text to a sibling node to Reverting, or to one or more child nodes. In any case, such text shuffling should not be part of this patch. I think we should have sibling sections "Reverting" and "Autorevert", with the latter describing both types of auto-reverting. And "Reverting" should have a cross-reference to "Autorevert" for automatic reverting of file-visiting buffers. Would you like to submit a patch to that effect? > > Saying this, the user option might need another name. What about > > `auto-revert-also-poll'? > > Naming is always hard. I started with `auto-revert-avoid-polling' but wanted to avoid a negative name. > I tried `auto-revert-also-poll' but it somehow didn't feel right; not all buffers use notification. > It is nothing I feel strongly about, so if you do prefer that name I'll change, but I've kept the original name in the patch for now. I actually think auto-revert-dont-poll is better, even though it's negative. Thanks.