From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Remove display member of glyph_string Date: Thu, 09 May 2019 20:02:26 +0300 Message-ID: <834l63h87x.fsf@gnu.org> References: <87a7fwe12f.fsf@gmail.com> <83ef58goru.fsf@gnu.org> <871s17ehmq.fsf@gmail.com> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="10677"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org To: Alex Gramiak Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu May 09 19:14:02 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hOmcL-0002c6-E8 for ged-emacs-devel@m.gmane.org; Thu, 09 May 2019 19:14:01 +0200 Original-Received: from localhost ([127.0.0.1]:58191 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hOmcK-0002Ev-BN for ged-emacs-devel@m.gmane.org; Thu, 09 May 2019 13:14:00 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:51158) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hOmRW-0001yy-OV for emacs-devel@gnu.org; Thu, 09 May 2019 13:02:53 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:45603) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hOmRW-0006mN-LO; Thu, 09 May 2019 13:02:50 -0400 Original-Received: from [176.228.60.248] (port=1655 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hOmRU-0004P3-4Q; Thu, 09 May 2019 13:02:50 -0400 In-reply-to: <871s17ehmq.fsf@gmail.com> (message from Alex Gramiak on Thu, 09 May 2019 10:07:25 -0600) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:236340 Archived-At: > From: Alex Gramiak > Cc: emacs-devel@gnu.org > Date: Thu, 09 May 2019 10:07:25 -0600 > > >> The only other location that FRAME_X_DISPLAY appears in non-X code is in > >> the argument to Free_Pixmap in image.c, which can hopefully be > >> refactored out in a later patch; at that point the other terms can > >> remove their trivial FRAME_X_DISPLAY definitions. > > > > So should we do both in one go, perhaps? > > Sure, here's a patch that does it: Thanks. > * src/msdos.h: > * src/nsgui.h: > * src/nsterm.h: > * src/w32term.h: Remove unused X-compatibility macros and typedefs. Please mention the macros and typedefs being removed explicitly, it is important for later forensics. > src/image.c | 24 ++---------------------- > src/msdos.h | 1 - > src/nsgui.h | 1 - > src/nsterm.h | 6 ------ > src/nsterm.m | 16 ++++++++++++++-- > src/termhooks.h | 8 ++++++++ > src/w32term.c | 14 ++++++++++++++ > src/w32term.h | 3 --- > src/xterm.c | 12 ++++++++++++ > 9 files changed, 50 insertions(+), 35 deletions(-) There's one more instance of FRAME_X_DISPLAY in xdisp.c which was left, and it will fail compilation on non-X platforms. Otherwise, this LGTM, thanks.