Re: [PATCH] Remove display member of glyph_string

[Eli Zaretskii <eliz@gnu.org>]

> From: Alex Gramiak <agrambot@gmail.com>
> Cc: emacs-devel@gnu.org
> Date: Thu, 09 May 2019 10:07:25 -0600
> 
> >> The only other location that FRAME_X_DISPLAY appears in non-X code is in
> >> the argument to Free_Pixmap in image.c, which can hopefully be
> >> refactored out in a later patch; at that point the other terms can
> >> remove their trivial FRAME_X_DISPLAY definitions.
> >
> > So should we do both in one go, perhaps?
> 
> Sure, here's a patch that does it:

Thanks.

> * src/msdos.h:
> * src/nsgui.h:
> * src/nsterm.h:
> * src/w32term.h: Remove unused X-compatibility macros and typedefs.

Please mention the macros and typedefs being removed explicitly, it is
important for later forensics.

>  src/image.c     | 24 ++----------------------
>  src/msdos.h     |  1 -
>  src/nsgui.h     |  1 -
>  src/nsterm.h    |  6 ------
>  src/nsterm.m    | 16 ++++++++++++++--
>  src/termhooks.h |  8 ++++++++
>  src/w32term.c   | 14 ++++++++++++++
>  src/w32term.h   |  3 ---
>  src/xterm.c     | 12 ++++++++++++
>  9 files changed, 50 insertions(+), 35 deletions(-)

There's one more instance of FRAME_X_DISPLAY in xdisp.c which was
left, and it will fail compilation on non-X platforms.

Otherwise, this LGTM, thanks.