From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#36032: 27.0.50; Massive GC when shift-selecting text in HELLO Date: Sat, 01 Jun 2019 10:21:11 +0300 Message-ID: <834l59wz2w.fsf@gnu.org> References: <83d0jywgna.fsf@gnu.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="235997"; mail-complaints-to="usenet@blaine.gmane.org" To: 36032@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jun 01 09:31:10 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hWyTu-000zGe-9L for geb-bug-gnu-emacs@m.gmane.org; Sat, 01 Jun 2019 09:31:10 +0200 Original-Received: from localhost ([127.0.0.1]:54039 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hWyTt-0000sv-8f for geb-bug-gnu-emacs@m.gmane.org; Sat, 01 Jun 2019 03:31:09 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:56104) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hWyTk-0000LW-9p for bug-gnu-emacs@gnu.org; Sat, 01 Jun 2019 03:31:01 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hWyL4-0006rH-Pm for bug-gnu-emacs@gnu.org; Sat, 01 Jun 2019 03:22:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51645) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hWyL4-0006r7-N7 for bug-gnu-emacs@gnu.org; Sat, 01 Jun 2019 03:22:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hWyL4-0007ha-Fr for bug-gnu-emacs@gnu.org; Sat, 01 Jun 2019 03:22:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 01 Jun 2019 07:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36032 X-GNU-PR-Package: emacs Original-Received: via spool by 36032-submit@debbugs.gnu.org id=B36032.155937369229566 (code B ref 36032); Sat, 01 Jun 2019 07:22:02 +0000 Original-Received: (at 36032) by debbugs.gnu.org; 1 Jun 2019 07:21:32 +0000 Original-Received: from localhost ([127.0.0.1]:36954 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hWyKa-0007gn-BP for submit@debbugs.gnu.org; Sat, 01 Jun 2019 03:21:32 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:40553) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hWyKY-0007gc-W6 for 36032@debbugs.gnu.org; Sat, 01 Jun 2019 03:21:31 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:33821) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hWyKT-0006aF-Rl for 36032@debbugs.gnu.org; Sat, 01 Jun 2019 03:21:25 -0400 Original-Received: from [176.228.60.248] (port=3784 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hWyKT-00018i-CK for 36032@debbugs.gnu.org; Sat, 01 Jun 2019 03:21:25 -0400 In-reply-to: <83d0jywgna.fsf@gnu.org> (message from Eli Zaretskii on Fri, 31 May 2019 22:47:05 +0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:159991 Archived-At: > Date: Fri, 31 May 2019 22:47:05 +0300 > From: Eli Zaretskii > > To reproduce: > > emacs -Q > C-h h > C-SPC > C-f C-f C-f .... > > You will see a ~0.5 sec delay after each C-f, before its effect of > extending the region is visible. The reason is GC after every > keystroke, and it seems to be caused by the changes in commit 479f51a. > That commit caused mode-line-default-help-echo to be called each time > Emacs needs to redisplay the mode line, and that seems to produce lots > of garbage, at least with the HELLO file. Actually, it looks like GC is not itself the culprit, it's the fact that by default we also compact the font caches as part of GC. The following patch fixes this in HELLO; any objections to push to master? (I'm beginning to seriously think we should turn off compacting the font caches by default, as it causes too many problems.) diff --git a/etc/HELLO b/etc/HELLO index a56a73b..33e664e 100644 --- a/etc/HELLO +++ b/etc/HELLO @@ -124,4 +124,5 @@ along with GNU Emacs. If not, see <. ;;; tab-width: 32 ;;; bidi-display-reordering: t ;;; coding: utf-8 +;;; inhibit-compacting-font-caches: t ;;; End: diff --git a/lisp/files.el b/lisp/files.el index 287ad14..35497b5 100644 --- a/lisp/files.el +++ b/lisp/files.el @@ -3297,6 +3297,7 @@ safe-local-eval-forms (default-directory . stringp) ;; C source code (fill-column . integerp) ;; C source code (indent-tabs-mode . booleanp) ;; C source code + (inhibit-compacting-font-caches . booleanp) ;; C source code (left-margin . integerp) ;; C source code (no-update-autoloads . booleanp) (lexical-binding . booleanp) ;; C source code