From: Eli Zaretskii <eliz@gnu.org>
To: 36032@debbugs.gnu.org
Subject: bug#36032: 27.0.50; Massive GC when shift-selecting text in HELLO
Date: Sat, 01 Jun 2019 10:21:11 +0300 [thread overview]
Message-ID: <834l59wz2w.fsf@gnu.org> (raw)
In-Reply-To: <83d0jywgna.fsf@gnu.org> (message from Eli Zaretskii on Fri, 31 May 2019 22:47:05 +0300)
> Date: Fri, 31 May 2019 22:47:05 +0300
> From: Eli Zaretskii <eliz@gnu.org>
>
> To reproduce:
>
> emacs -Q
> C-h h
> C-SPC
> C-f C-f C-f ....
>
> You will see a ~0.5 sec delay after each C-f, before its effect of
> extending the region is visible. The reason is GC after every
> keystroke, and it seems to be caused by the changes in commit 479f51a.
> That commit caused mode-line-default-help-echo to be called each time
> Emacs needs to redisplay the mode line, and that seems to produce lots
> of garbage, at least with the HELLO file.
Actually, it looks like GC is not itself the culprit, it's the fact
that by default we also compact the font caches as part of GC. The
following patch fixes this in HELLO; any objections to push to master?
(I'm beginning to seriously think we should turn off compacting the
font caches by default, as it causes too many problems.)
diff --git a/etc/HELLO b/etc/HELLO
index a56a73b..33e664e 100644
--- a/etc/HELLO
+++ b/etc/HELLO
@@ -124,4 +124,5 @@ along with GNU Emacs. If not, see <<https://www.gnu.org/licenses/>.
;;; tab-width: 32
;;; bidi-display-reordering: t
;;; coding: utf-8
+;;; inhibit-compacting-font-caches: t
;;; End:</x-charset>
diff --git a/lisp/files.el b/lisp/files.el
index 287ad14..35497b5 100644
--- a/lisp/files.el
+++ b/lisp/files.el
@@ -3297,6 +3297,7 @@ safe-local-eval-forms
(default-directory . stringp) ;; C source code
(fill-column . integerp) ;; C source code
(indent-tabs-mode . booleanp) ;; C source code
+ (inhibit-compacting-font-caches . booleanp) ;; C source code
(left-margin . integerp) ;; C source code
(no-update-autoloads . booleanp)
(lexical-binding . booleanp) ;; C source code
next prev parent reply other threads:[~2019-06-01 7:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-31 19:47 bug#36032: 27.0.50; Massive GC when shift-selecting text in HELLO Eli Zaretskii
2019-06-01 7:21 ` Eli Zaretskii [this message]
2019-06-01 7:49 ` martin rudalics
2019-06-01 7:53 ` martin rudalics
2019-06-01 11:53 ` Eli Zaretskii
2019-06-01 12:10 ` martin rudalics
2019-06-01 12:22 ` Eli Zaretskii
2019-06-01 14:01 ` martin rudalics
2019-06-01 15:54 ` Eli Zaretskii
2019-06-01 7:45 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=834l59wz2w.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=36032@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.