From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Unbreak build on macOS Date: Tue, 09 Jul 2019 19:08:49 +0300 Message-ID: <834l3v5gxa.fsf@gnu.org> References: <55EE5431-8EC2-4562-8F75-33151A0F086E@acm.org> <0C3B72C3-B0BF-4B41-A877-18B72BBD1549@acm.org> <83ef2z5iqu.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="231148"; mail-complaints-to="usenet@blaine.gmane.org" Cc: rcopley@gmail.com, eggert@cs.ucla.edu, emacs-devel@gnu.org To: mattiase@acm.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jul 09 18:14:14 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hkskw-000xq1-M6 for ged-emacs-devel@m.gmane.org; Tue, 09 Jul 2019 18:14:14 +0200 Original-Received: from localhost ([::1]:51678 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hksha-0005zU-Bp for ged-emacs-devel@m.gmane.org; Tue, 09 Jul 2019 12:10:46 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56599) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hksfy-0004NR-B7 for emacs-devel@gnu.org; Tue, 09 Jul 2019 12:09:07 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:53537) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hksfx-0003jz-Nn; Tue, 09 Jul 2019 12:09:05 -0400 Original-Received: from [176.228.60.248] (port=3795 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hksfu-0000Rm-D4; Tue, 09 Jul 2019 12:09:05 -0400 In-reply-to: <83ef2z5iqu.fsf@gnu.org> (message from Eli Zaretskii on Tue, 09 Jul 2019 18:29:29 +0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:238459 Archived-At: > Date: Tue, 09 Jul 2019 18:29:29 +0300 > From: Eli Zaretskii > Cc: rcopley@gmail.com, eggert@cs.ucla.edu, emacs-devel@gnu.org > > > From: Mattias EngdegÄrd > > Date: Tue, 9 Jul 2019 16:46:30 +0200 > > Cc: Paul Eggert , Emacs developers > > > > Sorry to hear that --- apparently font.h is being preprocessed with '#define open #rpl_open' on Windows. > > Not rpl_open, but sys_open, see nt/inc/ms-w32.h. > > > Would you try this smelly hack instead? > > I'd prefer open_font to open_. And then we should probably rename close to close_font as well. Thanks.