From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Severe regressions in context of keyboard macros Date: Tue, 15 Oct 2019 15:12:36 +0300 Message-ID: <834l0agqbv.fsf@gnu.org> References: <83a7aztoq9.fsf@gnu.org> <6b147564-cfea-1824-701f-33495958d304@web.de> <83d0fusvjd.fsf@gnu.org> <83wodynkuo.fsf@gnu.org> <83wodvl40w.fsf@gnu.org> <65332ac9-0e3f-fbd4-ac84-5ae4e7126d37@web.de> <83v9tfl0lc.fsf@gnu.org> <830f19fe-20dd-b3a3-fc50-26573760dbff@web.de> <490eaf69-c3fe-6ea3-8f89-c0d4d56c5b88@web.de> <835zlciwiv.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="187595"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org To: Christoph Arenz Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Oct 15 14:12:55 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iKLh6-000mdE-Dr for ged-emacs-devel@m.gmane.org; Tue, 15 Oct 2019 14:12:52 +0200 Original-Received: from localhost ([::1]:43054 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKLh5-0006VO-9a for ged-emacs-devel@m.gmane.org; Tue, 15 Oct 2019 08:12:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36663) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKLgx-0006VG-91 for emacs-devel@gnu.org; Tue, 15 Oct 2019 08:12:44 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:46180) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iKLgx-0000qO-5Y; Tue, 15 Oct 2019 08:12:43 -0400 Original-Received: from [176.228.60.248] (port=3041 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iKLgv-0004fa-LL; Tue, 15 Oct 2019 08:12:42 -0400 In-reply-to: (message from Christoph Arenz on Sun, 29 Sep 2019 19:42:56 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:241044 Archived-At: > Cc: emacs-devel@gnu.org > From: Christoph Arenz > Date: Sun, 29 Sep 2019 19:42:56 +0200 > > On 28.09.19 11:46, Eli Zaretskii wrote: > >> I spent some more time on this. The problem is bigger than stated in the > >> original bug report: > >> Any function key that follows a digit and is not separated by a or > >> is recorded twice in calc when defining a keyboard macro, e.g. > >> `1 2 + ' records "2++". > > Is this while using Calc, or is this in some other situation? > Just in Calc. I should have been a bit clearer what I meant with > `function' key: > While calc is reading digits, it recognizes it has rad a complete number > when reading or . > > Calc also recognizes a number when reading a calc function key when > reading digits. This is one path when calc reads this key a second time. > > > Here is lossage for such a case: >  1             ;; calcDigit-start >        ;; calcDigit-nondigit >  1             ;; calcDigit-start >  2             ;; calcDigit-key >  +             ;; calcDigit-key >  +             ;; calc-plus > > > Note the `+' being read twice. With the proposed patch, lossage looks > just the same -- just in case of keyboard macro recording, we avoid the > `+' being recorded twice. Lossage in this case looks like this: >           ;; kmacro-start-macro-or-insert-counter >  1            ;; calcDigit-start >       ;; calcDigit-nondigit >  1            ;; calcDigit-start >  2            ;; calcDigit-key >  +            ;; calcDigit-key >  ;; calc-plus >           ;; kmacro-end-or-call-macro > >> I am getting more confident that the patch below fixes this bug.Itfixes > >> a severe issue with macros in calc, does not make things worse and does > >> not interfere in case no macro is being defined. > >> > >> Your thoughts? > > If it works well for you in Calc, I will install it. > > > > Thanks. > Yes, the patch definitely improves the situation. Thanks! Thanks, I've finally installed your fix in Calc, it will be in the next Emacs release. Sorry for the long delay.