From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#37774: 27.0.50; new :extend attribute broke visuals of all themes and other packages Date: Thu, 31 Oct 2019 18:48:17 +0200 Message-ID: <834kzooo8e.fsf@gnu.org> References: <87o8xwrjba.fsf@bernoul.li> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="4511"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 37774@debbugs.gnu.org To: Jonas Bernoulli Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Oct 31 17:49:14 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iQDdJ-00011F-Gg for geb-bug-gnu-emacs@m.gmane.org; Thu, 31 Oct 2019 17:49:13 +0100 Original-Received: from localhost ([::1]:52682 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iQDdI-000197-02 for geb-bug-gnu-emacs@m.gmane.org; Thu, 31 Oct 2019 12:49:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42215) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iQDd9-000185-Gs for bug-gnu-emacs@gnu.org; Thu, 31 Oct 2019 12:49:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iQDd8-0004YH-Go for bug-gnu-emacs@gnu.org; Thu, 31 Oct 2019 12:49:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45336) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iQDd8-0004Wk-Dg for bug-gnu-emacs@gnu.org; Thu, 31 Oct 2019 12:49:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iQDd8-0002re-2o for bug-gnu-emacs@gnu.org; Thu, 31 Oct 2019 12:49:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 31 Oct 2019 16:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37774 X-GNU-PR-Package: emacs Original-Received: via spool by 37774-submit@debbugs.gnu.org id=B37774.157254050510961 (code B ref 37774); Thu, 31 Oct 2019 16:49:02 +0000 Original-Received: (at 37774) by debbugs.gnu.org; 31 Oct 2019 16:48:25 +0000 Original-Received: from localhost ([127.0.0.1]:54157 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iQDcX-0002qi-0h for submit@debbugs.gnu.org; Thu, 31 Oct 2019 12:48:25 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:33086) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iQDcW-0002qX-82 for 37774@debbugs.gnu.org; Thu, 31 Oct 2019 12:48:24 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:56924) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iQDcQ-0003OD-NX; Thu, 31 Oct 2019 12:48:18 -0400 Original-Received: from [176.228.60.248] (port=2705 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iQDcQ-00005R-4J; Thu, 31 Oct 2019 12:48:18 -0400 In-reply-to: <87o8xwrjba.fsf@bernoul.li> (message from Jonas Bernoulli on Thu, 31 Oct 2019 17:06:17 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:170536 Archived-At: > From: Jonas Bernoulli > Date: Thu, 31 Oct 2019 17:06:17 +0100 > > I believe that sometimes a face extends beyond eol even though there is > nothing (no explicit `:extend t` nor any `:inherit' what-so-ever) that > tells it to do so. Maybe it does make a difference whether the face is > used by an overlay or not. Or maybe that is completely irrelevant. > Other faces however do not extend past eol and I am unable to see how > these faces differ from the faces that do. > > You can verify that > (1) by making sure no theme is in use > (2) opening a Magit diff > (3) note how most faces extend beyond eol > (4) look at the definition of these faces and notice that there is > nothing that tells those faces to extend beyond eol. Yet they > do. > > Such faces include for example `magit-section-highlight' and > `magit-diff-added'. > > A counter example is `magit-diff-file-heading-highlight'. That does > not extend and I don't see how it is different from the other faces > that I mentioned. Is there an easier way of reproducing this than installing Magit and actually using it? Could you perhaps come up with a much simpler recipe that just defines a face like Magit does? The feature we are talking about is implemented in the display code, whereas Magit is a large and complex package. Mapping what one sees in Magit back to the display code is not an easy job, so anything you can do to ease that will be appreciated. Thanks.