From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: master ab36b56 1/2: ; * src/font.h (font_is_ignored): Add
 prototype to avoid warnings.
Date: Thu, 14 Nov 2019 16:49:50 +0200
Message-ID: <834kz65x81.fsf@gnu.org>
References: <20191114115158.1987.26946@vcs0.savannah.gnu.org>
 <20191114115159.EC9F020BC2@vcs0.savannah.gnu.org>
 <m2blted4pm.fsf@gmail.com> <83d0du5ye1.fsf@gnu.org> <m2tv76frkf.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226";
	logging-data="74873"; mail-complaints-to="usenet@blaine.gmane.org"
Cc: emacs-devel@gnu.org
To: Robert Pluim <rpluim@gmail.com>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Nov 14 15:50:21 2019
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.89)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1iVGRw-000JJf-L5
	for ged-emacs-devel@m.gmane.org; Thu, 14 Nov 2019 15:50:20 +0100
Original-Received: from localhost ([::1]:58374 helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1iVGRu-0001v3-UT
	for ged-emacs-devel@m.gmane.org; Thu, 14 Nov 2019 09:50:18 -0500
Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53303)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@gnu.org>) id 1iVGRj-0001rj-VX
 for emacs-devel@gnu.org; Thu, 14 Nov 2019 09:50:08 -0500
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:52498)
 by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@gnu.org>)
 id 1iVGRj-0005gM-QZ; Thu, 14 Nov 2019 09:50:07 -0500
Original-Received: from [176.228.60.248] (port=3095 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@gnu.org>)
 id 1iVGRg-0006BR-VL; Thu, 14 Nov 2019 09:50:07 -0500
In-reply-to: <m2tv76frkf.fsf@gmail.com> (message from Robert Pluim on Thu, 14
 Nov 2019 15:41:52 +0100)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Original-Sender: "Emacs-devel" <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Xref: news.gmane.org gmane.emacs.devel:242179
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/242179>

> From: Robert Pluim <rpluim@gmail.com>
> Cc: emacs-devel@gnu.org
> Date: Thu, 14 Nov 2019 15:41:52 +0100
> 
>     Eli> The paranoid warning options used by the developers' build causes GCC
>     Eli> to complain about non-static functions that have no prototype in
>     Eli> scope.
> 
> Oh, I donʼt run configure with --enable-gcc-warnings (I seem to
> remember Paul warning against that).

Neither do I.  But --enable-checking turns it on, AFAIR.

>     >> (and now we have two prototypes for that function, the other is in
>     >> gtkutil.h).
> 
>     Eli> That one should be removed, because gkutil.c (indirectly) includes
>     Eli> font.h, AFAICT.
> 
> Yes, which causes lots of warnings in a GTK build. Removed.

Thanks.