all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: lin.sun@zoom.us
Cc: larsi@gnus.org, 38426@debbugs.gnu.org
Subject: bug#38426: 27.0.50; [PATCH] * python.el: new function python-shell-send-statement
Date: Sat, 14 Dec 2019 14:17:16 +0200	[thread overview]
Message-ID: <834ky36r03.fsf@gnu.org> (raw)
In-Reply-To: <046101d5a690$b8e69bc0$2ab3d340$@zoom.us> (lin.sun@zoom.us)

> From: <lin.sun@zoom.us>
> Date: Fri, 29 Nov 2019 16:40:55 +0800
> 
> >From 61db0e91094297ddca302eaf691cf5b4ff82ebf6 Mon Sep 17 00:00:00 2001
> From: "lin.sun" <lin.sun@zoom.us>
> Date: Fri, 29 Nov 2019 03:10:12 -0500
> Subject: [PATCH] * python.el: new function python-shell-send-statement
> 
> Add new function `python-shell-send-statement' and bind to key "C-c
> C-e" for sending statement under cursor to inferior Python process.

Thanks.  A few comments below:

> +(defun python-shell-send-statement (&optional send-main msg)
> +  "Send the statement delimited by `python-nav-beginning-of-statement' and

The first line of a doc string should be a complete sentence, and it
should mention the function's arguments.

> +`python-nav-end-of-statement' to inferior Python process. When optional
                                                           ^^
Our convention is to leave 2 spaces between sentences in documentation
and comments, per US English rules.

> +                                                         When optional
> +argument MSG is non-nil, forces display of a user-friendly message if
> there's
> +no process running; default to t when called interactively. If there is
> region
> +be activated, it present as `python-shell-send-region'."

These lines are too long, please wrap them to make them shorter,
preferably no more than 75 characters.

Please also provide a ChangeLog style commit log message, as described
in CONTRIBUTE, and please mention the bug number there.

And finally, this new command needs to be mentioned in NEWS, under
"Python mode".

Thanks.





  parent reply	other threads:[~2019-12-14 12:17 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-29  8:40 bug#38426: 27.0.50; [PATCH] * python.el: new function python-shell-send-statement lin.sun
2019-12-07  9:45 ` Eli Zaretskii
2019-12-10  2:46 ` bug#38426: " LinSun
2019-12-10  3:25   ` Eli Zaretskii
2019-12-13  2:08     ` lin.sun
2019-12-13  7:28       ` Eli Zaretskii
2019-12-13  7:56         ` lin.sun
2019-12-14 12:17 ` Eli Zaretskii [this message]
2019-12-15  8:43   ` lin.sun
2019-12-21  9:19     ` Eli Zaretskii
2019-12-23  1:29       ` lin.sun
2019-12-15  8:52   ` lin.sun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=834ky36r03.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=38426@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    --cc=lin.sun@zoom.us \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.