From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#39360: Add :extend attribute to show-paren-mode expression face Date: Fri, 31 Jan 2020 17:32:42 +0200 Message-ID: <834kwbljz9.fsf@gnu.org> References: <8336bwm5xm.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="23120"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 39360@debbugs.gnu.org To: =?UTF-8?Q?Cl=C3=A9ment?= Pit-Claudel Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jan 31 17:08:20 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ixYqC-0005yh-I3 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 31 Jan 2020 17:08:20 +0100 Original-Received: from localhost ([::1]:55426 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ixYqB-0001La-Hr for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 31 Jan 2020 11:08:19 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50548) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ixYJ3-0007g3-BF for bug-gnu-emacs@gnu.org; Fri, 31 Jan 2020 10:34:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ixYJ1-0007ZQ-QL for bug-gnu-emacs@gnu.org; Fri, 31 Jan 2020 10:34:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60143) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ixYJ1-0007ZI-MW for bug-gnu-emacs@gnu.org; Fri, 31 Jan 2020 10:34:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ixYJ0-0003ub-JW for bug-gnu-emacs@gnu.org; Fri, 31 Jan 2020 10:34:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 31 Jan 2020 15:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39360 X-GNU-PR-Package: emacs Original-Received: via spool by 39360-submit@debbugs.gnu.org id=B39360.158048479614980 (code B ref 39360); Fri, 31 Jan 2020 15:34:02 +0000 Original-Received: (at 39360) by debbugs.gnu.org; 31 Jan 2020 15:33:16 +0000 Original-Received: from localhost ([127.0.0.1]:37883 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ixYIG-0003tY-5k for submit@debbugs.gnu.org; Fri, 31 Jan 2020 10:33:16 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:41128) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ixYIE-0003tM-Ku for 39360@debbugs.gnu.org; Fri, 31 Jan 2020 10:33:14 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:47423) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ixYI9-0005AY-G2; Fri, 31 Jan 2020 10:33:09 -0500 Original-Received: from [176.228.60.248] (port=2380 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ixYI4-0001Cv-D0; Fri, 31 Jan 2020 10:33:09 -0500 In-reply-to: (message from =?UTF-8?Q?Cl=C3=A9ment?= Pit-Claudel on Fri, 31 Jan 2020 09:52:25 -0500) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:175501 Archived-At: > Cc: 39360@debbugs.gnu.org > From: Clément Pit-Claudel > Date: Fri, 31 Jan 2020 09:52:25 -0500 > > > Please describe a use case where this problem shows up, I'm not sure I > > understand it completely. More accurately, I don't think I understand > > why you think we must have the previous behavior with this face, > > i.e. why the new behavior is "wrong". > > Unless people were complaining about the old behavior for this particular face, I think that behavior was fine. IMO it was not fine, because Emacs was behaving differently from every other application out there which supports some form of highlighting text that spans several lines. The old behavior was also inconsistent between different face attributes: background color behaved differently from underline, for example, and GUI frames behaved differently from TTY frames. > More to the point, though, since the newline is inside the parentheses, it makes sense to me to extend the highlight continuously up to the edge of the window. The newline is inside the parentheses, but the empty space to the right of the newline is not part of the text. Why should it be highlighted? > >> I might have missed discussions about this; is there a reason why :extend t isn't the default? > > > > Because the whole idea of introducing :extend was that almost all > > faces don't need this attribute. > > I see. The new default looks weird to me, but I'm sure I'll get used to it. The question I'd like to ask is whether you'll get used to it wrt the show-paren-mode face. > Is there a reason to highlight one blank space at the end of each line, though, instead of only highlighting the text? That blank space stands for the newline, so if the newline has that face, the space glyph at EOL gets highlighted to indicate that fact.