all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: 39380@debbugs.gnu.org, Wolfgang.Scherer@gmx.de
Subject: bug#39380: 26.3: Opening files in vc-dir-mode with differing root and working dir fails
Date: Fri, 07 Feb 2020 11:53:32 +0200	[thread overview]
Message-ID: <834kw2g1ur.fsf@gnu.org> (raw)
In-Reply-To: <0a8b11c8-1c5c-33ed-e5a1-e7ad5b090929@yandex.ru> (message from Dmitry Gutov on Thu, 6 Feb 2020 16:38:54 +0300)

> Cc: Eli Zaretskii <eliz@gnu.org>
> From: Dmitry Gutov <dgutov@yandex.ru>
> Date: Thu, 6 Feb 2020 16:38:54 +0300
> 
> >> Good catch, thank you. Could you try this patch?
> >>
> > Works fine. Directory listing in vc-dir-mode is truncated at sub-directory. Files are processed correctly.
> 
> Very good.
> 
> Eli, I'd like to get it into emacs-27. OK?

I'll have to ask you to walk me through the change and explain how it
solves the original issue.

I tried to figure that out myself, but it's too hard: the patch has no
log message, the function being changed has no doc string which could
describe its contract, and the Mercurial documentation I've read seems
to contradict what you are doing (e.g., it says "re:" should be
immediately followed by a regexp).  Sorry, I cannot make up my mind
whether this is a safe change without understanding it better.

Thanks.





  reply	other threads:[~2020-02-07  9:53 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-01  0:13 bug#39380: 26.3: Opening files in vc-dir-mode with differing root and working dir fails Wolfgang Scherer
2020-02-01  7:20 ` Dmitry Gutov
2020-02-02 22:35   ` Wolfgang Scherer
2020-02-03 13:11     ` Dmitry Gutov
2020-02-04 16:04       ` Wolfgang Scherer
2020-02-05 15:56         ` Dmitry Gutov
2020-02-06 13:25           ` Wolfgang Scherer
2020-02-06 13:38             ` Dmitry Gutov
2020-02-07  9:53               ` Eli Zaretskii [this message]
2020-02-07 11:03                 ` Dmitry Gutov
2020-02-07 14:00                   ` Eli Zaretskii
2020-02-08  1:20                     ` Dmitry Gutov
2020-02-08  8:04                       ` Eli Zaretskii
2020-02-08  9:36                         ` Dmitry Gutov
2020-02-08 10:11                           ` Eli Zaretskii
2020-02-11 22:36                             ` Dmitry Gutov
2020-02-01  7:20 ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=834kw2g1ur.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=39380@debbugs.gnu.org \
    --cc=Wolfgang.Scherer@gmx.de \
    --cc=dgutov@yandex.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.