From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#38992: 27.0.60; when enabled, fido-mode seems to break vc-git-grep Date: Thu, 05 Mar 2020 08:08:42 +0200 Message-ID: <834kv3wcyd.fsf@gnu.org> References: <288610218.111246.1578330546916@office.mailbox.org> <98df50d8-44fb-448e-e893-f20601f1ca54@yandex.ru> <51d12435-274b-be14-95b8-f790804f1a61@yandex.ru> <157c6af1-c900-188d-490c-4f48ea17da3d@yandex.ru> <5dc9535d-9b2f-56f1-2e63-b75ff3aaaf55@yandex.ru> <9da3ee1b-7315-41d2-192b-9db470d50ba4@yandex.ru> <83blqik9wv.fsf@gnu.org> <838slhglog.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="74895"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 38992@debbugs.gnu.org, joaotavora@gmail.com, waah@yellowfrog.io To: Dmitry Gutov , Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Mar 05 07:10:17 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j9ji5-000JOQ-Ki for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 05 Mar 2020 07:10:17 +0100 Original-Received: from localhost ([::1]:43656 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j9ji4-0002tz-Kt for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 05 Mar 2020 01:10:16 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56625) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j9jhr-0002td-0g for bug-gnu-emacs@gnu.org; Thu, 05 Mar 2020 01:10:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j9jhp-000426-Rs for bug-gnu-emacs@gnu.org; Thu, 05 Mar 2020 01:10:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36133) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j9jhp-00041Z-Oo for bug-gnu-emacs@gnu.org; Thu, 05 Mar 2020 01:10:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j9jhp-0007Ld-J8 for bug-gnu-emacs@gnu.org; Thu, 05 Mar 2020 01:10:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 Mar 2020 06:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38992 X-GNU-PR-Package: emacs Original-Received: via spool by 38992-submit@debbugs.gnu.org id=B38992.158338855128173 (code B ref 38992); Thu, 05 Mar 2020 06:10:01 +0000 Original-Received: (at 38992) by debbugs.gnu.org; 5 Mar 2020 06:09:11 +0000 Original-Received: from localhost ([127.0.0.1]:42106 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j9jh0-0007KL-Ta for submit@debbugs.gnu.org; Thu, 05 Mar 2020 01:09:11 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:41368) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j9jgy-0007K7-BM for 38992@debbugs.gnu.org; Thu, 05 Mar 2020 01:09:08 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:38995) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1j9jgs-0003eh-5G; Thu, 05 Mar 2020 01:09:02 -0500 Original-Received: from [176.228.60.248] (port=2930 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1j9jgr-0006eb-DM; Thu, 05 Mar 2020 01:09:01 -0500 In-Reply-To: (message from Dmitry Gutov on Thu, 5 Mar 2020 02:15:21 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:176881 Archived-At: > Cc: 38992@debbugs.gnu.org, joaotavora@gmail.com, monnier@iro.umontreal.ca, > waah@yellowfrog.io > From: Dmitry Gutov > Date: Thu, 5 Mar 2020 02:15:21 +0200 > > > diff --git a/lisp/icomplete.el b/lisp/icomplete.el > > index a1a67e2330..52429fdf37 100644 > > --- a/lisp/icomplete.el > > +++ b/lisp/icomplete.el > > @@ -541,7 +541,7 @@ icomplete-exhibit > > (icomplete--completion-table) > > (icomplete--completion-predicate) > > (if (window-minibuffer-p) > > - (not minibuffer-completion-confirm))))) > > + (eq minibuffer-completion-confirm t))))) > > (buffer-undo-list t) > > deactivate-mark) > > ;; Do nothing if while-no-input was aborted. > > The above is a simple bugfix of "why the hell not" variety: I don't > think that code worked well before that patch, i.e. it treated the > values of nil and t of REQUIRE-MATCH the same. Good thing that only > affected the choice of parens to print in the minibuffer. > > > IOW, some code which just assumes that anything non-nil and > > non-confirm must be confirm-after-completion, or the other way > > around. It's an incompatible change. > > I'm not arguing that is isn't. But looking at the actual uses out there, > the chief popular alternatives to completing-read-default don't seem to > be affected. And this variable is bound inside completing-read-default, > so only particular kind of code could really use it. Breakage is > possible, of course, but I'm fairly sure the affected audience would be > minimal. > > Anyway, see the alternative patches in the branch 'fido-mode-fix' I just > pushed. > > > Is the problem this attempts to fix really serious? Or is it just a > > minor inconvenience? It isn't the original one that started the bug > > report, right? > > The patches fix both an inconvenience (one that started this bug report, > I'd say it is serious enough to make users stumped) and a bug. See my > previous message in this bug report for details. Thanks for the explanations. Stefan, any thoughts on whether this is safe for emacs-27?