From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#39980: [PATCH] gnus-shorten-url: Improve and avoid args-out-of-range error Date: Sun, 12 Apr 2020 17:35:31 +0300 Message-ID: <834ktolqks.fsf@gnu.org> References: <20200308090630.41238-1-stepnem@gmail.com> <87pndf17v5.fsf@gnus.org> <87zhcinbdl.fsf@gmail.com> <87d09ezudv.fsf@gnus.org> <83zhciby6s.fsf@gnu.org> <87imioo963.fsf@gmail.com> <875zeinoc0.fsf@gnus.org> <87wo6lc9n8.fsf@gmail.com> <83blnxkn7i.fsf@gnu.org> <87o8rxc72a.fsf@gmail.com> <83a73hklq3.fsf@gnu.org> <87k12lc4dz.fsf@gmail.com> <838sj0lt72.fsf@gnu.org> <873698dc70.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="57484"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, 39980@debbugs.gnu.org To: =?UTF-8?Q?=C5=A0t=C4=9Bp=C3=A1n_?= =?UTF-8?Q?N=C4=9Bmec?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Apr 12 16:36:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jNdiU-000Eq3-QI for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 12 Apr 2020 16:36:10 +0200 Original-Received: from localhost ([::1]:34050 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jNdiT-0004jK-TD for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 12 Apr 2020 10:36:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34716) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jNdiN-0004hu-1Z for bug-gnu-emacs@gnu.org; Sun, 12 Apr 2020 10:36:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jNdiM-0003P9-4T for bug-gnu-emacs@gnu.org; Sun, 12 Apr 2020 10:36:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47102) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jNdiM-0003P4-1N for bug-gnu-emacs@gnu.org; Sun, 12 Apr 2020 10:36:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jNdiL-00026G-Th for bug-gnu-emacs@gnu.org; Sun, 12 Apr 2020 10:36:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 12 Apr 2020 14:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39980 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 39980-submit@debbugs.gnu.org id=B39980.15867021528047 (code B ref 39980); Sun, 12 Apr 2020 14:36:01 +0000 Original-Received: (at 39980) by debbugs.gnu.org; 12 Apr 2020 14:35:52 +0000 Original-Received: from localhost ([127.0.0.1]:58648 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jNdiB-00025j-UB for submit@debbugs.gnu.org; Sun, 12 Apr 2020 10:35:52 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:47801) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jNdiB-00025V-8z for 39980@debbugs.gnu.org; Sun, 12 Apr 2020 10:35:51 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:59581) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1jNdi6-0003IB-3j; Sun, 12 Apr 2020 10:35:46 -0400 Original-Received: from [176.228.60.248] (port=3275 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jNdi2-0003FP-VL; Sun, 12 Apr 2020 10:35:44 -0400 In-Reply-To: <873698dc70.fsf@gmail.com> (message from =?UTF-8?Q?=C5=A0t=C4=9Bp=C3=A1n_?= =?UTF-8?Q?N=C4=9Bmec?= on Sun, 12 Apr 2020 16:13:23 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:178250 Archived-At: > From: Štěpán Němec > Cc: larsi@gnus.org, 39980@debbugs.gnu.org > Date: Sun, 12 Apr 2020 16:13:23 +0200 > > On Sun, 12 Apr 2020 16:38:57 +0300 > Eli Zaretskii wrote: > > >> You mean instead of reusing an existing function, fix `gnus-shorten-url' > >> without using it? > > > > Almost: the "existing function" doesn't really exist, you introduced > > it with the same changeset, right? > > No, it's the (hopefully) tried and true `ediff-truncate-string-left', > only renamed and moved to subr-x to be generally available. That's exactly what I'd like to avoid on the release branch. It's fine for master, of course. > The changes are cosmetic. It would even be possible (in emacs-27, to > avoid moving anything), to use `ediff-truncate-string-left' > unchanged, but that would require gnus-sum to (require 'ediff-init), > which would be crazy. It would be crazy and also somewhat risky. Let's just come up with a local change in gnus-sum, for the emacs-27 branch, okay?