From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: rcopley@gmail.com, 40661@debbugs.gnu.org
Subject: bug#40661: Crash in regex search during redisplay
Date: Sat, 18 Apr 2020 14:57:16 +0300 [thread overview]
Message-ID: <834kthatwj.fsf@gnu.org> (raw)
In-Reply-To: <jwvr1wm9ke8.fsf-monnier+emacs@gnu.org> (message from Stefan Monnier on Fri, 17 Apr 2020 12:00:27 -0400)
> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: rcopley@gmail.com, dancol@dancol.org, 40661@debbugs.gnu.org
> Date: Fri, 17 Apr 2020 12:00:27 -0400
>
> >> > Obviously, we cannot allow GC to run while regex routines do their
> >> > work, because they are passed C pointers to buffer text. The question
> >> > is, where to disable GC? We could do it inside
> >> > update_syntax_table_forward, but UPDATE_SYNTAX_TABLE_FORWARD is called
> >> > from many places that evidently have no problems with GC. So my
> >> > suggestion would be to disable GC inside re_match_2_internal instead.
> >> > Comments?
> >> Looks fine to me.
> > So you prefer disabling GC to setting the inhibit_shrinking flag?
> > I tend to agree with Daniel here, FWIW.
>
> No, what I meant was that I'm fine with doing it "inside
> re_match_2_internal" instead of "inside update_syntax_table_forward".
> But I prefer if the "it" is setting `inhibit_shrinking` instead of
> inhibiting the GC altogether.
OK, thank you and Daniel for the feedback, and thanks to Richard for
finding this bug in the first place.
I installed a fix on the emacs-27 branch, it avoids the crashes in the
recipe posted by Richard. Please eyeball the fix, in case I made some
stupid mistake (my environment is rather noisy today, so I trust
myself even less than I usually do).
next prev parent reply other threads:[~2020-04-18 11:57 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-16 14:35 bug#40661: Crash in regex search during redisplay Richard Copley
2020-04-16 15:36 ` Eli Zaretskii
2020-04-16 16:33 ` Eli Zaretskii
2020-04-16 16:42 ` Daniel Colascione
2020-04-16 16:56 ` Richard Copley
2020-04-16 17:24 ` Daniel Colascione
2020-04-16 19:35 ` Richard Copley
2020-04-17 11:22 ` Eli Zaretskii
2020-04-17 13:55 ` Eli Zaretskii
2020-04-17 14:01 ` Daniel Colascione
2020-04-17 15:28 ` Stefan Monnier
2020-04-17 15:50 ` Eli Zaretskii
2020-04-17 16:00 ` Stefan Monnier
2020-04-18 11:57 ` Eli Zaretskii [this message]
2020-04-20 18:30 ` Richard Copley
2020-04-20 19:06 ` Eli Zaretskii
2020-04-20 23:04 ` Richard Copley
2020-09-30 3:49 ` Lars Ingebrigtsen
2020-04-16 16:57 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=834kthatwj.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=40661@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=rcopley@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.