From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#42904: [PATCH] Non-Unicode frame title crashes Emacs on macOS Date: Thu, 20 Aug 2020 22:13:09 +0300 Message-ID: <834koxcere.fsf@gnu.org> References: <83lfidgtc7.fsf@gnu.org> <838sedgq2x.fsf@gnu.org> <02F52D43-7EAB-4E61-A567-E8CCD11D856B@acm.org> <20200817195610.GA70682@breton.holly.idiocy.org> <3F71EF82-A143-4E3A-AEF3-8A236091891D@acm.org> <20200818084306.GA89999@breton.holly.idiocy.org> <243A5DA8-2865-485D-A8A2-1F543B046BAA@acm.org> <20200818172824.GA90575@breton.holly.idiocy.org> <83h7sxcux5.fsf@gnu.org> <5719A3A9-06A2-42AF-A290-726D96B6E6F1@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16360"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 42904@debbugs.gnu.org, alan@idiocy.org To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Aug 20 21:14:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k8q0o-00049s-6K for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 20 Aug 2020 21:14:10 +0200 Original-Received: from localhost ([::1]:42142 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k8q0n-0005fU-98 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 20 Aug 2020 15:14:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43888) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k8q0g-0005fO-Mj for bug-gnu-emacs@gnu.org; Thu, 20 Aug 2020 15:14:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60842) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k8q0g-0007To-DQ for bug-gnu-emacs@gnu.org; Thu, 20 Aug 2020 15:14:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k8q0g-0007FE-85 for bug-gnu-emacs@gnu.org; Thu, 20 Aug 2020 15:14:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 20 Aug 2020 19:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42904 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 42904-submit@debbugs.gnu.org id=B42904.159795080827803 (code B ref 42904); Thu, 20 Aug 2020 19:14:02 +0000 Original-Received: (at 42904) by debbugs.gnu.org; 20 Aug 2020 19:13:28 +0000 Original-Received: from localhost ([127.0.0.1]:44155 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k8q07-0007EM-PH for submit@debbugs.gnu.org; Thu, 20 Aug 2020 15:13:28 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:33648) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k8q04-0007E7-I0 for 42904@debbugs.gnu.org; Thu, 20 Aug 2020 15:13:26 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:46487) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k8pzy-0007SE-87; Thu, 20 Aug 2020 15:13:18 -0400 Original-Received: from [176.228.60.248] (port=3175 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1k8pzx-0003Ln-7f; Thu, 20 Aug 2020 15:13:17 -0400 In-Reply-To: <5719A3A9-06A2-42AF-A290-726D96B6E6F1@acm.org> (message from Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= on Thu, 20 Aug 2020 20:46:17 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:185766 Archived-At: > From: Mattias Engdegård > Date: Thu, 20 Aug 2020 20:46:17 +0200 > Cc: alan@idiocy.org, 42904@debbugs.gnu.org > > 20 aug. 2020 kl. 15.24 skrev Eli Zaretskii : > > > What would you like xdisp.c to do instead in this case? If there's an > > alternative way of dealing with such frame titles that is better in > > some sense, we could either adopt it for all platforms, or only for > > NS. > > Not sure how to deal with it, but maybe it's just a matter of settling on multibyte representation when building the title (as in mode_line_noprop_buf and so on)? I don't think I understand. mode_line_noprop_buf gets the bytes, and then we call make_string on it, so the result is the same as the one you'd like to avoid. Or am I missing something? By "settling on multibyte representation", do you mean that we should convert raw bytes to their multibyte form? Or do you mean something else? > I presume that the current ambiguity comes from when there were good reasons to build these strings in various unibyte encodings, but maybe it isn't motivated today? Again, what would you like to have instead? Would calling str_as_multibyte do what you want? The reason we build a unibyte string is that the presence of raw bytes generally means a unibyte string is desired; it's a heuristic. It is also the simplest thing to do in this case, and always works because it doesn't change the byte sequence of the original string. > If it is at all any trouble at all, just leave it as it is. On the other hand, perhaps we have found a way to simplify the code by accident. See above: maybe str_as_multibyte is what you want?