From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#43409: 28.0.50; Segfault on non-UTF-8 path Date: Tue, 15 Sep 2020 17:15:06 +0300 Message-ID: <834knz9led.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30944"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 43409@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Sep 15 16:18:01 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kIBmT-0007v2-2U for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 15 Sep 2020 16:18:01 +0200 Original-Received: from localhost ([::1]:57272 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kIBmS-0005U4-3m for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 15 Sep 2020 10:18:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53690) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kIBkY-0003AU-N3 for bug-gnu-emacs@gnu.org; Tue, 15 Sep 2020 10:16:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48435) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kIBkY-0008VW-E7 for bug-gnu-emacs@gnu.org; Tue, 15 Sep 2020 10:16:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kIBkY-0005Y5-Ac for bug-gnu-emacs@gnu.org; Tue, 15 Sep 2020 10:16:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 15 Sep 2020 14:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43409 X-GNU-PR-Package: emacs Original-Received: via spool by 43409-submit@debbugs.gnu.org id=B43409.160017931221266 (code B ref 43409); Tue, 15 Sep 2020 14:16:02 +0000 Original-Received: (at 43409) by debbugs.gnu.org; 15 Sep 2020 14:15:12 +0000 Original-Received: from localhost ([127.0.0.1]:59981 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIBjk-0005Ww-Hw for submit@debbugs.gnu.org; Tue, 15 Sep 2020 10:15:12 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:46696) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIBjf-0005WW-EX for 43409@debbugs.gnu.org; Tue, 15 Sep 2020 10:15:10 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:45649) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kIBjY-0008FI-Ld; Tue, 15 Sep 2020 10:15:02 -0400 Original-Received: from [176.228.60.248] (port=4264 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kIBjX-0005HV-0Y; Tue, 15 Sep 2020 10:14:59 -0400 In-Reply-To: (message from Lars Ingebrigtsen on Tue, 15 Sep 2020 02:16:36 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:188114 Archived-At: > From: Lars Ingebrigtsen > Date: Tue, 15 Sep 2020 02:16:36 +0200 > > Hitting RET on that kills Emacs. Running under gdb, I get this > backtrace: > > #0 terminate_due_to_signal > (sig=sig@entry=6, backtrace_limit=backtrace_limit@entry=40) at emacs.c:378 > #1 0x00005555555984fe in emacs_abort () at sysdep.c:2280 > #2 0x0000555555596a9a in multibyte_chars_in_text (ptr=, > ptr@entry=0x5555565f0870 "f\363o", nbytes=nbytes@entry=3) > at character.c:447 > #3 0x00005555555d412b in display_mode_element > (it=, depth=, field_width=, precision=, elt=, props=, risky=) at xdisp.c:25644 My bad, sorry: I used a wrong API for the job. Does the below solve the problem? diff --git a/src/xdisp.c b/src/xdisp.c index 10ddb53dba..615f0ca7cf 100644 --- a/src/xdisp.c +++ b/src/xdisp.c @@ -25641,8 +25641,10 @@ display_mode_element (struct it *it, int depth, int field_width, int precision, /* Non-ASCII characters in SPEC should cause mode-line element be displayed as a multibyte string. */ ptrdiff_t nbytes = strlen (spec); - if (multibyte_chars_in_text ((const unsigned char *)spec, - nbytes) != nbytes) + ptrdiff_t nchars, mb_nbytes; + parse_str_as_multibyte ((const unsigned char *)spec, nbytes, + &nchars, &mb_nbytes); + if (!(nbytes == nchars || nbytes != mb_nbytes)) multibyte = true; switch (mode_line_target)