From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: resize_mini_window question Date: Fri, 18 Sep 2020 22:39:29 +0300 Message-ID: <834knu50y6.fsf@gnu.org> References: <20200918150113.4vz5vq3krfslrwdz.ref@Ergus> <20200918150113.4vz5vq3krfslrwdz@Ergus> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29086"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Ergus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Sep 18 22:20:53 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kJMsF-0007Tc-Vb for ged-emacs-devel@m.gmane-mx.org; Fri, 18 Sep 2020 22:20:51 +0200 Original-Received: from localhost ([::1]:44638 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kJMsF-0002Wc-0e for ged-emacs-devel@m.gmane-mx.org; Fri, 18 Sep 2020 16:20:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33684) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kJME1-0007iV-7c for emacs-devel@gnu.org; Fri, 18 Sep 2020 15:39:17 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:55346) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kJMDz-00061g-RE; Fri, 18 Sep 2020 15:39:15 -0400 Original-Received: from [176.228.60.248] (port=2995 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kJMDy-0002KY-Q2; Fri, 18 Sep 2020 15:39:15 -0400 In-Reply-To: <20200918150113.4vz5vq3krfslrwdz@Ergus> (message from Ergus on Fri, 18 Sep 2020 17:01:13 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:256136 Archived-At: > Date: Fri, 18 Sep 2020 17:01:13 +0200 > From: Ergus > Cc: Eli Zaretskii > > 1) Modify resize_mini_window to use the minibuffer's font size to > calculate the height when Vmax_mini_window_height is an int. (don't know > if it is possible to access the minibuffer font size from there or if > this could produce some undesired side effect) > > 2) Modify the documentation of max-mini-window-height to specify that if > an integer, it specifies a number of lines respecting to the frame's > default font, not the minibuffer's visible lines. > > 3) Just force the text to fit ignoring that the number of real visible > lines will be different than max-mini-window-height. (This will be seen > as ignoring the max-mini-window-height) > > What do you think is better? I agree with what Stefan says: our only practical choice is 2. Minibuffer messages can legitimately use different fonts in each of their lines, so using some different font will just move the problem to other use cases. In a nutshell, max-mini-window-height sets the limit in pixels, it just expresses that limit in units of the canonical character height.