all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Ergus <spacibba@aol.com>
Cc: emacs-devel@gnu.org
Subject: Re: resize_mini_window question
Date: Fri, 18 Sep 2020 22:39:29 +0300	[thread overview]
Message-ID: <834knu50y6.fsf@gnu.org> (raw)
In-Reply-To: <20200918150113.4vz5vq3krfslrwdz@Ergus> (message from Ergus on Fri, 18 Sep 2020 17:01:13 +0200)

> Date: Fri, 18 Sep 2020 17:01:13 +0200
> From: Ergus <spacibba@aol.com>
> Cc: Eli Zaretskii <eliz@gnu.org>
> 
> 1) Modify resize_mini_window to use the minibuffer's font size to
> calculate the height when Vmax_mini_window_height is an int. (don't know
> if it is possible to access the minibuffer font size from there or if
> this could produce some undesired side effect)
> 
> 2) Modify the documentation of max-mini-window-height to specify that if
> an integer, it specifies a number of lines respecting to the frame's
> default font, not the minibuffer's visible lines.
> 
> 3) Just force the text to fit ignoring that the number of real visible
> lines will be different than max-mini-window-height. (This will be seen
> as ignoring the max-mini-window-height)
> 
> What do you think is better?

I agree with what Stefan says: our only practical choice is 2.
Minibuffer messages can legitimately use different fonts in each of
their lines, so using some different font will just move the problem
to other use cases.

In a nutshell, max-mini-window-height sets the limit in pixels, it
just expresses that limit in units of the canonical character height.



      parent reply	other threads:[~2020-09-18 19:39 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20200918150113.4vz5vq3krfslrwdz.ref@Ergus>
2020-09-18 15:01 ` resize_mini_window question Ergus
2020-09-18 15:30   ` Stefan Monnier
2020-09-18 15:56     ` Ergus
2020-09-18 16:02       ` Stefan Monnier
2020-09-18 16:50         ` Ergus
2020-09-18 19:49           ` Stefan Monnier
2020-09-18 19:39   ` Eli Zaretskii [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=834knu50y6.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=spacibba@aol.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.