From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#6227: Color isearch regexp submatches differently Date: Sun, 20 Sep 2020 12:53:57 +0300 Message-ID: <834kns22q2.fsf@gnu.org> References: <87bpca15ja.fsf@mail.jurta.org> <87wruv1ohr.fsf@mail.jurta.org> <877hmvtn9t.fsf@mail.jurta.org> <874ohyppfs.fsf@mail.jurta.org> <8739ww1tjp.fsf@mail.jurta.org> <87d3vyaodq.fsf@mail.jurta.org> <87hbla4nl4.fsf@mail.jurta.org> <87mu1llak3.fsf@gnus.org> <83lfh50zxa.fsf@gnu.org> <87eemwss3t.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10837"; mail-complaints-to="usenet@ciao.gmane.io" Cc: lennart.borgman@gmail.com, 6227@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Sep 20 11:55:18 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kJw3x-0002iQ-G9 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 20 Sep 2020 11:55:17 +0200 Original-Received: from localhost ([::1]:57886 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kJw3w-000828-44 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 20 Sep 2020 05:55:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58792) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kJw3j-00081V-5f for bug-gnu-emacs@gnu.org; Sun, 20 Sep 2020 05:55:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37206) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kJw3i-00053w-SO for bug-gnu-emacs@gnu.org; Sun, 20 Sep 2020 05:55:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kJw3i-0000zQ-Ry for bug-gnu-emacs@gnu.org; Sun, 20 Sep 2020 05:55:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 20 Sep 2020 09:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6227 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 6227-submit@debbugs.gnu.org id=B6227.16005956483714 (code B ref 6227); Sun, 20 Sep 2020 09:55:02 +0000 Original-Received: (at 6227) by debbugs.gnu.org; 20 Sep 2020 09:54:08 +0000 Original-Received: from localhost ([127.0.0.1]:48748 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJw2q-0000xq-En for submit@debbugs.gnu.org; Sun, 20 Sep 2020 05:54:08 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:51890) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJw2o-0000xJ-CE for 6227@debbugs.gnu.org; Sun, 20 Sep 2020 05:54:07 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:60897) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kJw2h-000503-V4; Sun, 20 Sep 2020 05:53:59 -0400 Original-Received: from [176.228.60.248] (port=2349 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kJw2h-0002Q5-I7; Sun, 20 Sep 2020 05:53:59 -0400 In-Reply-To: <87eemwss3t.fsf@gnus.org> (message from Lars Ingebrigtsen on Sun, 20 Sep 2020 11:41:10 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:188477 Archived-At: > From: Lars Ingebrigtsen > Cc: juri@jurta.org, lennart.borgman@gmail.com, 6227@debbugs.gnu.org > Date: Sun, 20 Sep 2020 11:41:10 +0200 > > Eli Zaretskii writes: > > >> Anybody else got any comments on this? > > > > Comment #1: Do we really want to turn this feature on by default? > > I don't see why not. It's just a more detailed visualisation. But with slightly different colors. How do we know long-time users of Isearch will understand what they mean, unless they deliberately turn on this option? > > Comment #2: This seems to effectively disable the feature on displays > > that have fewer than 88 colors. Is that intentional? If so, why > > doesn't the documentation say so? > > I'm guessing it's just cargo-culting off of the isearch face: > > (defface isearch > '((((class color) (min-colors 88) (background light)) I don't understand: the 'isearch' face has definitions for all kinds of displays, even for monochrome ones: (defface isearch '((((class color) (min-colors 88) (background light)) ;; The background must not be too dark, for that means ;; the character is hard to see when the cursor is there. (:background "magenta3" :foreground "lightskyblue1")) (((class color) (min-colors 88) (background dark)) (:background "palevioletred2" :foreground "brown4")) (((class color) (min-colors 16)) (:background "magenta4" :foreground "cyan1")) (((class color) (min-colors 8)) (:background "magenta4" :foreground "cyan1")) (t (:inverse-video t)))