From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Making TTY menus more visual Date: Tue, 13 Oct 2020 17:33:24 +0300 Message-ID: <834kmy2o23.fsf@gnu.org> References: <087df85a965fac6555a755c1bbebf1ea@finder.org> <83r1qhf5ii.fsf@gnu.org> <83wo07g0bf.fsf@gnu.org> <85afa5c0a0a789c6047e92f6ecfa9fcc@finder.org> <72bbff31bcf46be917c9e8d8236cad75@finder.org> <838scmfq4f.fsf@gnu.org> <83y2kme50p.fsf@gnu.org> <033517da1ce6762b3d3c656dad4d8f98@finder.org> <835z7pdvcp.fsf@gnu.org> <0168b49ea0f2b5533f6e20c6ad73eb0c@finder.org> <835z7l876k.fsf@gnu.org> <54d686f28c49c0b86c4a52ba48cf2486@finder.org> <83sgan5to0.fsf@gnu.org> <78d53fb994e86bb2d8c7fd313cdfa8a2@finder.org> <83blha5yla.fsf@gnu.org> <184d04bc36d1a7204238d8508ec48531@finder.org> <83362j4i58.fsf@gnu.org> <8a6b6ce3f194ccf418709fe46ce0f1bb@finder.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35368"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Jared Finder Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Oct 13 16:34:01 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kSLNI-00096M-O9 for ged-emacs-devel@m.gmane-mx.org; Tue, 13 Oct 2020 16:34:00 +0200 Original-Received: from localhost ([::1]:39448 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kSLNH-00034F-MN for ged-emacs-devel@m.gmane-mx.org; Tue, 13 Oct 2020 10:33:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36746) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kSLMc-0002E6-HA for emacs-devel@gnu.org; Tue, 13 Oct 2020 10:33:18 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:36397) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kSLMb-000235-VH; Tue, 13 Oct 2020 10:33:17 -0400 Original-Received: from [176.228.60.248] (port=1836 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kSLMa-0007oh-9p; Tue, 13 Oct 2020 10:33:16 -0400 In-Reply-To: <8a6b6ce3f194ccf418709fe46ce0f1bb@finder.org> (message from Jared Finder on Mon, 12 Oct 2020 14:30:38 -0700) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:257536 Archived-At: > Date: Mon, 12 Oct 2020 14:30:38 -0700 > From: Jared Finder > Cc: emacs-devel@gnu.org > > Thanks, I investigated further and I have an improved patch attached. > In addition to keeping the same interactive spec, it also is logically > independent of my changes to enable xterm-mouse based menu interaction. > I also attached repro.el, which I used to help understand the behavior > of xterm-mouse. Thanks, I think this is a much better variant. > The manual is not clear of the format of a posn for clicks outside a > window, such as on the menu bar or tab bar. From the behavior I see, > posn-window will return nil and posn-x-y will return (x . y) in frame > coordinates. I rely on that in this patch. If this is accurate, I can > update the manual. Are you sure posn-window cannot return a frame? For example, on a TTY, I get this: (posn-at-x-y 0 0 (selected-frame)) => (# nil (0 . 0) 0) And (0,0) are coordinates in the frame's menu bar. Does it make sense to install this patch on its own? If so, we can install it without waiting for the legal paperwork, the changes are small enough.