From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: empty-directory predicate, native implementation Date: Wed, 14 Oct 2020 17:08:36 +0300 Message-ID: <834kmw293v.fsf@gnu.org> References: <83y2ka18t7.fsf@gnu.org> <83d01m0wjp.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28072"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Arthur Miller Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Oct 14 16:08:56 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kShSa-0007Dj-HE for ged-emacs-devel@m.gmane-mx.org; Wed, 14 Oct 2020 16:08:56 +0200 Original-Received: from localhost ([::1]:55868 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kShSZ-0002Kg-KJ for ged-emacs-devel@m.gmane-mx.org; Wed, 14 Oct 2020 10:08:55 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59204) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kShS6-0001th-MT for emacs-devel@gnu.org; Wed, 14 Oct 2020 10:08:26 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:58398) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kShS5-0002ah-SV; Wed, 14 Oct 2020 10:08:25 -0400 Original-Received: from [176.228.60.248] (port=1421 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kShS5-0008Pg-9b; Wed, 14 Oct 2020 10:08:25 -0400 In-Reply-To: (message from Arthur Miller on Tue, 13 Oct 2020 21:59:47 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:257631 Archived-At: > From: Arthur Miller > Cc: emacs-devel@gnu.org > Date: Tue, 13 Oct 2020 21:59:47 +0200 > > Can I ask two questions, just for my learning; you seem to handle > ascii/unicode "manually"; in w32.c I have seen quite a few places where > switch is done on if(w32_unicode_filenames); is it possible to somehow > pass to configure script if Emacs should be compiled with wide or asci > version of win api? The idea is not to decide this at configure and compile time, but at runtime. That way, the same Emacs binary can run both on systems that support "wide" (a.k.a. "Unicode") APIs and on systems that don't. Think about users who download the "official" binaries from the GNU FTP site. Besides, the compile-time "switch" to Unicode makes all TCHAR variables be wchar_t under the hood, which means one cannot use strlen, strcat, etc. So this "feature" is a mixed blessing, especially when the internal encoding is UTF-8. > Second question: block_input; is there some general rule(s) what calls you > enclose with block/unblock_input? I guess OS will anyway block the > process after call to SYS_getdents so I didn't enclosed it; but I am not > sure if that would be needed at all or not. See the commentary in src/blockinput.h, I hope it answers the question.