From: Eli Zaretskii <eliz@gnu.org>
To: Eliza Velasquez <exv@google.com>
Cc: 25547@debbugs.gnu.org, alexhutcheson@google.com,
monnier@iro.umontreal.ca
Subject: bug#25547: 25.1.91; emacsclient -c creates frames on the wrong display
Date: Fri, 06 Nov 2020 07:39:34 +0200 [thread overview]
Message-ID: <834km39h7t.fsf@gnu.org> (raw)
In-Reply-To: <CAK1djOoquVkX19Re7Bf=FhFO0ZYUFXDXq_diie+tseeoU5wxMg@mail.gmail.com> (bug-gnu-emacs@gnu.org)
> Cc: 25547@debbugs.gnu.org, Alex Hutcheson <alexhutcheson@google.com>
> Date: Thu, 5 Nov 2020 15:41:08 -0800
> From: Eliza Velasquez via "Bug reports for GNU Emacs,
> the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
>
> +(defun server-create-frame (nowait proc &optional parameters)
This function's name is too general, and therefore will confuse
someone who tries to learn how server.el works. Please name it
according to the convention used by 2 other functions in server.el
that create GUI and TTY frames.
Btw, why can't you use server-create-tty-frame here? IOW, I don't
think I understand this comment:
> + ((equal tty-type "dumb")
> + ;; Dumb terminals should create frames without
> + ;; preference for tty or window system (bug#25547)
> + (server-create-frame nowait proc frame-parameters))
Thanks.
next prev parent reply other threads:[~2020-11-06 5:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-26 18:09 bug#25547: 25.1.91; emacsclient -c creates frames on the wrong display Alex Hutcheson
2020-11-02 22:37 ` Stefan Monnier
[not found] ` <CAK1djOorpaeoMU-gtd+hQnWWK8tOaER6OPYgukYrn=V1cDh+aQ@mail.gmail.com>
[not found] ` <jwvsg9rtghs.fsf-monnier+emacs@gnu.org>
2020-11-03 18:36 ` Eliza Velasquez via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-11-05 2:00 ` Eliza Velasquez via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-11-05 4:44 ` Stefan Monnier
2020-11-05 23:41 ` Eliza Velasquez via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-11-06 0:55 ` Eliza Velasquez via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-11-06 5:39 ` Eli Zaretskii [this message]
2020-11-06 19:14 ` Eliza Velasquez via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-11-06 22:07 ` Stefan Monnier
2020-11-07 8:04 ` Eli Zaretskii
2020-11-10 0:14 ` Eliza Velasquez via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-11-11 3:14 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=834km39h7t.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=25547@debbugs.gnu.org \
--cc=alexhutcheson@google.com \
--cc=exv@google.com \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.