From: Eli Zaretskii <eliz@gnu.org>
To: Ulrich Mueller <ulm@gentoo.org>
Cc: acm@muc.de, stefan@marxist.se, emacs-devel@gnu.org
Subject: Re: Yikes! easy-menu-add is suddenly compiled to `ignore', without any warning.
Date: Wed, 07 Apr 2021 14:37:16 +0300 [thread overview]
Message-ID: <834kgiba1f.fsf@gnu.org> (raw)
In-Reply-To: <ua6qa72wm@gentoo.org> (message from Ulrich Mueller on Wed, 07 Apr 2021 13:24:57 +0200)
> From: Ulrich Mueller <ulm@gentoo.org>
> Date: Wed, 07 Apr 2021 13:24:57 +0200
> Cc: Alan Mackenzie <acm@muc.de>, emacs-devel@gnu.org
>
> >>>>> On Wed, 07 Apr 2021, Stefan Kangas wrote:
>
> > This function is only relevant in XEmacs, so if this is important to
> > you I recommend changing any such call to say:
>
> > (when (featurep 'xemacs)
> > (easy-menu-add foo-menu))
>
> Why can't it be left in place, though? An alias for "ignore" is cheap
> and requires zero maintenance.
"Zero maintenance" is an exaggeration, IME. Not every code fragment
that uses these compatibility shims is as clear-cut as the snippet
above; more often than not, when working on code which references
those shims, one needs to dig quite deeply into the sources until
he/she understands that the code is a no-op in Emacs. That digging
takes/wastes time and effort.
> OTOH, removing it will make the life of those people who try to keep
> their packages compatible with XEmacs more complicated.
I'm sorry, but that ship has sailed several months ago. Gobs of
XEmacs compatibility features were removed already, after the removal
move was announced. Are you saying we should reinstate all of them
back? If not, what is so special about this particular one?
next prev parent reply other threads:[~2021-04-07 11:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-07 9:29 Yikes! easy-menu-add is suddenly compiled to `ignore', without any warning Alan Mackenzie
2021-04-07 10:06 ` Stefan Kangas
2021-04-07 11:24 ` Ulrich Mueller
2021-04-07 11:37 ` Eli Zaretskii [this message]
2021-04-07 14:14 ` Ulrich Mueller
2021-04-07 14:24 ` Eli Zaretskii
2021-04-07 14:30 ` XEmacs compatibility (was: Yikes! easy-menu-add is suddenly compiled to `ignore', without any warning) Stefan Monnier
2021-04-07 11:58 ` Yikes! easy-menu-add is suddenly compiled to `ignore', without any warning Alan Mackenzie
2021-04-07 12:43 ` Stefan Kangas
2021-04-07 11:41 ` Eli Zaretskii
2021-04-07 12:32 ` Alan Mackenzie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=834kgiba1f.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=acm@muc.de \
--cc=emacs-devel@gnu.org \
--cc=stefan@marxist.se \
--cc=ulm@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.