From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#48264: [PATCH v3 00/15] Speeding up setting the default for DEFVAR_PER_BUFFER vars Date: Fri, 07 May 2021 14:05:40 +0300 Message-ID: <834kfedcsb.fsf@gnu.org> References: <877dkbsj9d.fsf@catern.com> <20210506213346.9730-1-sbaugh@catern.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33453"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 48264@debbugs.gnu.org To: Spencer Baugh Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri May 07 13:06:09 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1leyJ7-0008bZ-F2 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 07 May 2021 13:06:09 +0200 Original-Received: from localhost ([::1]:53272 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1leyJ6-0005Nw-H6 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 07 May 2021 07:06:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38556) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1leyJ0-0005N2-6T for bug-gnu-emacs@gnu.org; Fri, 07 May 2021 07:06:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59903) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1leyIz-0001C5-UU for bug-gnu-emacs@gnu.org; Fri, 07 May 2021 07:06:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1leyIz-0003HT-Pt for bug-gnu-emacs@gnu.org; Fri, 07 May 2021 07:06:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 07 May 2021 11:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48264 X-GNU-PR-Package: emacs Original-Received: via spool by 48264-submit@debbugs.gnu.org id=B48264.162038555512603 (code B ref 48264); Fri, 07 May 2021 11:06:01 +0000 Original-Received: (at 48264) by debbugs.gnu.org; 7 May 2021 11:05:55 +0000 Original-Received: from localhost ([127.0.0.1]:43216 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leyIt-0003HD-0c for submit@debbugs.gnu.org; Fri, 07 May 2021 07:05:55 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:58482) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leyIq-0003H7-Og for 48264@debbugs.gnu.org; Fri, 07 May 2021 07:05:53 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:34826) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1leyIl-00014G-KA; Fri, 07 May 2021 07:05:47 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2816 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.86_2) (envelope-from ) id 1leyIk-00081o-KZ; Fri, 07 May 2021 07:05:47 -0400 In-Reply-To: <20210506213346.9730-1-sbaugh@catern.com> (message from Spencer Baugh on Thu, 6 May 2021 17:33:31 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:205916 Archived-At: > From: Spencer Baugh > Date: Thu, 6 May 2021 17:33:31 -0400 > Cc: Spencer Baugh > > This patch series fixes bug#48264 by speeding up changes to the > default value for DEFVAR_PER_BUFFER vars, whether by let or > set-default. Such changes are now constant time, and run as fast as > changes to non-default values. [...] I think some of this (the "new implementation") should be in some commentary in buffer.c, and at least some of the rest should be in the commit log message. It makes no sense, IMNSHO, to have such a detailed description here, and then lose it when installing the changes. Thanks.