From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#33847: 27.0.50; emacsclient does not find server socket Date: Sun, 25 Jul 2021 10:27:43 +0300 Message-ID: <834kciyhsg.fsf@gnu.org> References: <8a6fc59c-08b3-e274-4fb1-74674c79540a@cs.ucla.edu> <27d2f2eb-8956-4088-f3ec-5ff6c2cf2e8f@cs.ucla.edu> <87eeo27v6k.fsf@gnus.org> <83lfi79klf.fsf@gnu.org> <831rjya5yy.fsf@gnu.org> <8333533f-08ec-acd4-2fbf-f06e78591e98@cs.ucla.edu> <83v9h99awv.fsf@gnu.org> <878s1yjy20.fsf@gnus.org> <83lf5y2t78.fsf@gnu.org> <878s1yi8jc.fsf@gnus.org> <83h7gm2r4j.fsf@gnu.org> <87wnphe06g.fsf@gnus.org> <87r1fpdzuy.fsf@gnus.org> <838s1w1b7x.fsf@gnu.org> <5f457b50-c1bd-4856-33c7-f85edf111bd0@cs.ucla.edu> <83v950yv7i.fsf@gnu.org> <5d2f6394-2fc0-e20a-9018-0ea59f399ba2@cs.ucla.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4812"; mail-complaints-to="usenet@ciao.gmane.io" Cc: teika@gmx.com, 33847@debbugs.gnu.org, larsi@gnus.org, ulm@gentoo.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jul 25 09:29:12 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m7YZU-000146-GF for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 25 Jul 2021 09:29:12 +0200 Original-Received: from localhost ([::1]:42168 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m7YZR-0005ry-Jo for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 25 Jul 2021 03:29:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49214) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m7YZL-0005qD-AQ for bug-gnu-emacs@gnu.org; Sun, 25 Jul 2021 03:29:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35919) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m7YZL-0001Y6-3N for bug-gnu-emacs@gnu.org; Sun, 25 Jul 2021 03:29:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m7YZK-00039S-Hk for bug-gnu-emacs@gnu.org; Sun, 25 Jul 2021 03:29:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 25 Jul 2021 07:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33847 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 33847-submit@debbugs.gnu.org id=B33847.162719809012049 (code B ref 33847); Sun, 25 Jul 2021 07:29:02 +0000 Original-Received: (at 33847) by debbugs.gnu.org; 25 Jul 2021 07:28:10 +0000 Original-Received: from localhost ([127.0.0.1]:47465 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m7YYP-00038D-Rm for submit@debbugs.gnu.org; Sun, 25 Jul 2021 03:28:10 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:51304) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m7YYN-00037h-Jk for 33847@debbugs.gnu.org; Sun, 25 Jul 2021 03:28:04 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:60952) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m7YYH-0000fX-Jm; Sun, 25 Jul 2021 03:27:57 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3730 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m7YYH-0000zp-42; Sun, 25 Jul 2021 03:27:57 -0400 In-Reply-To: <5d2f6394-2fc0-e20a-9018-0ea59f399ba2@cs.ucla.edu> (message from Paul Eggert on Sat, 24 Jul 2021 16:31:21 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:210691 Archived-At: > Cc: larsi@gnus.org, teika@gmx.com, 33847@debbugs.gnu.org, ulm@gentoo.org > From: Paul Eggert > Date: Sat, 24 Jul 2021 16:31:21 -0700 > > From 4f8392f633cbd3b978c05b972983cfef82be4e7b Mon Sep 17 00:00:00 2001 > From: Paul Eggert > Date: Sat, 24 Jul 2021 16:11:16 -0700 > Subject: [PATCH 4/4] Port recent Gnulib changes to MS-Windows > MIME-Version: 1.0 > Content-Type: text/plain; charset=UTF-8 > Content-Transfer-Encoding: 8bit > > * nt/gnulib-cfg.mk (OMIT_GNULIB_MODULE_free-posix) > (OMIT_GNULIB_MODULE_malloc-posix) > (OMIT_GNULIB_MODULE_realloc-gnu) > (OMIT_GNULIB_MODULE_realloc-posix): > New macros, since we don’t want these modules on MS-Windows. > * src/w32heap.c (heap_alloc, heap_realloc): New functions. > (malloc_after_dump, realloc_after_dump, realloc_before_dump): > Use them. Thanks, this LGTM, but I have one minor request: > +static void * > +heap_alloc (size_t size) > +{ > + void *p = size <= PTRDIFF_MAX ? HeapAlloc (heap, 0, size | !size) : NULL; Please add a comment here to explain the rationale for the "size | !size" trick. > +static void * > +heap_realloc (void *ptr, size_t size) > +{ > + void *p = (size <= PTRDIFF_MAX > + ? HeapReAlloc (heap, 0, ptr, size | !size) Likewise here. Btw, HeapAlloc does return a non-NULL pointer if SIZE is zero, so I'm not sure the protection is needed. But it cannot hurt.