From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#50660: 28.0.50; Text artifacting when the cursor moves over text under mouse face that originally displayed a box Date: Mon, 20 Sep 2021 10:07:27 +0300 Message-ID: <834kaf3ets.fsf@gnu.org> References: <87czp6ysw7.fsf.ref@yahoo.com> <87czp6ysw7.fsf@yahoo.com> <87y27uro4c.fsf@gnus.org> <877dfdz9ni.fsf@yahoo.com> <831r5l5d6d.fsf@gnu.org> <87h7egy8jo.fsf@yahoo.com> <838rzs4i09.fsf@gnu.org> <87fsu06oxi.fsf@yahoo.com> <83ee9j3ju3.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26941"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, 50660@debbugs.gnu.org To: luangruo@yahoo.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 20 09:08:51 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mSDQ2-0006qn-SR for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 20 Sep 2021 09:08:50 +0200 Original-Received: from localhost ([::1]:58208 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mSDQ1-0006Xe-Rx for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 20 Sep 2021 03:08:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37554) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mSDPG-0005eL-5w for bug-gnu-emacs@gnu.org; Mon, 20 Sep 2021 03:08:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57514) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mSDPF-0001nH-V4 for bug-gnu-emacs@gnu.org; Mon, 20 Sep 2021 03:08:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mSDPF-0002Jr-QK for bug-gnu-emacs@gnu.org; Mon, 20 Sep 2021 03:08:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 20 Sep 2021 07:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50660 X-GNU-PR-Package: emacs Original-Received: via spool by 50660-submit@debbugs.gnu.org id=B50660.16321216638890 (code B ref 50660); Mon, 20 Sep 2021 07:08:01 +0000 Original-Received: (at 50660) by debbugs.gnu.org; 20 Sep 2021 07:07:43 +0000 Original-Received: from localhost ([127.0.0.1]:40827 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSDOw-0002JK-Ot for submit@debbugs.gnu.org; Mon, 20 Sep 2021 03:07:42 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:48652) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mSDOu-0002J4-Rt for 50660@debbugs.gnu.org; Mon, 20 Sep 2021 03:07:41 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:51488) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mSDOp-0001SL-MB; Mon, 20 Sep 2021 03:07:35 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1936 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mSDOp-0006v7-9I; Mon, 20 Sep 2021 03:07:35 -0400 In-Reply-To: <83ee9j3ju3.fsf@gnu.org> (message from Eli Zaretskii on Mon, 20 Sep 2021 08:19:16 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:214832 Archived-At: > Date: Mon, 20 Sep 2021 08:19:16 +0300 > From: Eli Zaretskii > Cc: larsi@gnus.org, 50660@debbugs.gnu.org > > However, it is IMO wrong to "fix" the glyphs' pixel_width to account > for the box face. Walking through the code, I now see that we already update the pixel_width of the border glyphs due to the box's vertical line. So set_cursor_from_row does its job correctly, and I still don't understand why any change would be needed in it. I guess you are saying that in the problematic scenario the pixel_width of the glyphs remains the same, even though the box dimensions have changed or the box attribute disappeared? If so, I think the problem is not where the cursor is drawn or its position is computed, the problem is where we redraw a portion of text due to change of mouse highlight, i.e. inside draw_row_with_mouse_face and friends.