From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#50752: 28.0.50; easy-menu-define lowers the menu-bar key Date: Tue, 19 Oct 2021 19:01:38 +0300 Message-ID: <834k9dc8bh.fsf@gnu.org> References: <87bl4jvudm.fsf@gnus.org> <837dehp248.fsf@gnu.org> <87czo96shw.fsf@gnus.org> <87wnmh5bes.fsf@gnus.org> <87wnmh3p9k.fsf@gnus.org> <87v91tfzrw.fsf@gnus.org> <87r1chfz80.fsf@gnus.org> <83r1chcjof.fsf@gnu.org> <87mtn5fc9s.fsf@gnus.org> <83bl3lchrp.fsf@gnu.org> <87ee8hfajg.fsf@gnus.org> <875yttf8qr.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6418"; mail-complaints-to="usenet@ciao.gmane.io" Cc: stefan@marxist.se, shuguang79@qq.com, 50752@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Oct 19 18:43:39 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mcsDD-0001SG-EG for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 19 Oct 2021 18:43:39 +0200 Original-Received: from localhost ([::1]:52304 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mcsDC-0005FR-4F for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 19 Oct 2021 12:43:38 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34456) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mcrYw-00070M-Rn for bug-gnu-emacs@gnu.org; Tue, 19 Oct 2021 12:02:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40180) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mcrYw-0002lp-IF for bug-gnu-emacs@gnu.org; Tue, 19 Oct 2021 12:02:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mcrYw-0004xP-Gb for bug-gnu-emacs@gnu.org; Tue, 19 Oct 2021 12:02:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 19 Oct 2021 16:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50752 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 50752-submit@debbugs.gnu.org id=B50752.163465930619026 (code B ref 50752); Tue, 19 Oct 2021 16:02:02 +0000 Original-Received: (at 50752) by debbugs.gnu.org; 19 Oct 2021 16:01:46 +0000 Original-Received: from localhost ([127.0.0.1]:51724 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mcrYf-0004wo-Uq for submit@debbugs.gnu.org; Tue, 19 Oct 2021 12:01:46 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:60614) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mcrYY-0004wW-Ai for 50752@debbugs.gnu.org; Tue, 19 Oct 2021 12:01:43 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:57630) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mcrYR-0002HS-V8; Tue, 19 Oct 2021 12:01:32 -0400 Original-Received: from [87.69.77.57] (port=2667 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mcrYO-0004JH-Py; Tue, 19 Oct 2021 12:01:29 -0400 In-Reply-To: <875yttf8qr.fsf@gnus.org> (message from Lars Ingebrigtsen on Tue, 19 Oct 2021 15:24:12 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:217577 Archived-At: > From: Lars Ingebrigtsen > Cc: stefan@marxist.se, shuguang79@qq.com, 50752@debbugs.gnu.org > Date: Tue, 19 Oct 2021 15:24:12 +0200 > > + /* If downcasing changed an ASCII character into a non-ASCII > + character (this can happen in some locales, like the Turkish > + "I"), use the multibyte algorithm. */ > + if (SINGLE_BYTE_CHAR_P (ch) && !SINGLE_BYTE_CHAR_P (cased)) > + return do_casify_multibyte_string (ctx, obj); > + SSET (obj, i, make_char_unibyte (cased)); Like I said elsewhere, I'd prefer to use ASCII rules in that case. It's safer, and definitely less surprising. Whoever wants Turkish rules will need to submit multibyte strings, even for ASCII characters.