all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Gregory Heytings <gregory@heytings.org>
Cc: luangruo@yahoo.com, larsi@gnus.org, 52053@debbugs.gnu.org
Subject: bug#52053: 29.0.50; Nonsensical button "C-x C-f" in scratch buffer
Date: Thu, 25 Nov 2021 16:16:18 +0200	[thread overview]
Message-ID: <834k805nil.fsf@gnu.org> (raw)
In-Reply-To: <612d659daad03d6bc73d@heytings.org> (message from Gregory Heytings on Thu, 25 Nov 2021 13:41:50 +0000)

> Date: Thu, 25 Nov 2021 13:41:50 +0000
> From: Gregory Heytings <gregory@heytings.org>
> cc: luangruo@yahoo.com, larsi@gnus.org, 52053@debbugs.gnu.org
> 
> AFAICS, the options are:
> 
> 1. Detect inside substitute-command-keys whether the string is for a 
> *Help* buffer.  That's what the patch does, it's the simplest solution 
> from the point of view of those who call s-c-k.
> 
> 2. Add an optional parameter to s-c-k to indicate whether the string is 
> for a non-*Help* buffer.  That's a reasonable alternative, but there are 
> ~450 calls to s-c-k in the trunk, each would have to be checked.
> 
> 3. Add a variable and let-bind it around the calls to s-c-k to indicate 
> when the string is for a non-*Help* buffer.
> 
> 4. Let-bind help-link-key-to-documentation to nil around the calls to 
> s-c-k to indicate that the calls to help-mode--add-function-link should be 
> skipped.  ISTM that this is not generic enough, if in six months we had 
> another similar feature it would be necessary to let-bind two variables 
> around calls for non-*Help* buffers, and so forth.

I think the best solution is to change the default value of
help-link-key-to-documentation to be nil, and then bind it to non-nil
in Help commands.

I'm not sure I understand what additional feature you have in mind and
how such an additional feature could be related to this discussion.
So please elaborate on that part.





  reply	other threads:[~2021-11-25 14:16 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <87czmr5gr7.fsf.ref@yahoo.com>
2021-11-23 10:05 ` bug#52053: 29.0.50; Nonsensical button "C-x C-f" in scratch buffer Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-24  6:17   ` Phil Sainty
2021-11-24  7:53   ` Lars Ingebrigtsen
2021-11-24  9:28     ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-24 10:58       ` Lars Ingebrigtsen
2021-11-24 11:15         ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-24 11:27           ` Lars Ingebrigtsen
2021-11-24 11:36             ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-24 16:39               ` Lars Ingebrigtsen
2021-11-24 17:05                 ` Andreas Schwab
2021-11-25  0:45                 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-25 13:34                   ` Lars Ingebrigtsen
2021-11-26  0:38                     ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-26 12:36                       ` Lars Ingebrigtsen
2021-11-26 12:52                         ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-25 10:23   ` Gregory Heytings
2021-11-25 10:59     ` Eli Zaretskii
2021-11-25 11:07       ` Gregory Heytings
2021-11-25 11:21         ` Eli Zaretskii
2021-11-25 12:47           ` Robert Pluim
2021-11-25 13:20             ` Eli Zaretskii
2021-11-25 13:36               ` Lars Ingebrigtsen
2021-11-25 13:41           ` Gregory Heytings
2021-11-25 14:16             ` Eli Zaretskii [this message]
2021-11-25 14:55               ` Gregory Heytings
2021-11-25 15:15                 ` Eli Zaretskii
2021-11-25 22:45                   ` Gregory Heytings
2021-11-26  6:26                     ` Eli Zaretskii
2021-11-26  9:24                       ` Robert Pluim
2021-11-26 11:13                         ` Eli Zaretskii
2021-11-26 11:17                           ` Robert Pluim
2021-11-27 16:06                       ` Gregory Heytings
2021-11-27 16:08                         ` Gregory Heytings
2021-11-29 13:56                           ` Lars Ingebrigtsen
2021-11-29 14:05                             ` Eli Zaretskii
2021-11-29 14:13                               ` Lars Ingebrigtsen
2021-11-29 17:59                           ` Stefan Kangas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=834k805nil.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=52053@debbugs.gnu.org \
    --cc=gregory@heytings.org \
    --cc=larsi@gnus.org \
    --cc=luangruo@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.