From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Incorrect font weight selected Date: Mon, 20 Dec 2021 17:16:07 +0200 Message-ID: <834k732too.fsf@gnu.org> References: <87pmpv708h.fsf@wavexx.thregr.org> <83r1abcb93.fsf@gnu.org> <87y24jqahr.fsf@wavexx.thregr.org> <83ilvnc6z4.fsf@gnu.org> <875yrmyk8q.fsf@wavexx.thregr.org> <87y24grwp6.fsf@wavexx.thregr.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37980"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Yuri D'Elia Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Dec 20 17:18:32 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mzLMt-0009bo-TN for ged-emacs-devel@m.gmane-mx.org; Mon, 20 Dec 2021 17:18:32 +0100 Original-Received: from localhost ([::1]:34144 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mzLMp-0002qo-56 for ged-emacs-devel@m.gmane-mx.org; Mon, 20 Dec 2021 11:18:27 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:35816) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mzKPC-0000ph-5a for emacs-devel@gnu.org; Mon, 20 Dec 2021 10:16:51 -0500 Original-Received: from fencepost.gnu.org ([209.51.188.10]:52194) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mzKOt-0004le-DG; Mon, 20 Dec 2021 10:16:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=OEP0eUO42iduHvMibgo0yRKhzp/3GOeYqO3uSHdMxBs=; b=Fcc5j34xn/T8 fNVLoBo4t60MdlLNBwMyPOEeEA3xs4Y7q6IhUNm/8OpgU5W13VpP1cxMNCEfVjwqqtnhpAXi5jR/i CoEX3F9ouW/UboVCbEALCBt5TfYsAOb5rX+16rPrl1HV2TV6a6EvnByg1txhkfimARFJTdaegyBkC NwYdS0nWzA2B+aXFMDcYfCfirVRPtCfrpXPP3P3J9uY9FNUtrnIoRJOIZa6JPk6wa6m9kIiRLg8EA iz3wk4xUbbOUXu0K2mEfRIaqEeEH6a5MC6Cb1rpiLuQym3B2Hne84VYlF7KzlyyatEOL8k3zDPr4N RxeKlwjhe52E90jMUL/KJQ==; Original-Received: from [87.69.77.57] (port=2619 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mzKOX-0006jY-2w; Mon, 20 Dec 2021 10:16:12 -0500 In-Reply-To: <87y24grwp6.fsf@wavexx.thregr.org> (message from Yuri D'Elia on Mon, 20 Dec 2021 00:24:20 +0100) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:282511 Archived-At: > From: Yuri D'Elia > Cc: emacs-devel@gnu.org > Date: Mon, 20 Dec 2021 00:24:20 +0100 > > Note how both frames are now bold. Please note the mode-line face as > well. I'm not changing the face there. The incorrect weight selection is > also affecting the face there. > > Indeed, it seems that any font weight which is within "100" in the > weight table can be susceptible to bad selection. Commit > 1b2511fa2aed460120a36765ba16c14e355eef1d by itself makes sense. We > likely have a problem elsewhere. > > Maybe font_sort_entities is not sorting the matches correctly by weight, > or we are calling it wrong in some places. > > Cannot go further at the moment. Thanks, I think you are getting closer to the root cause. Please keep going. I'm not wedded to the change in 1b2511f: it was originally concocted for MS-Windows, so maybe it is not right for Fontconfig-based platforms.