From: Eli Zaretskii <eliz@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 54136@debbugs.gnu.org, jporterbugs@gmail.com
Subject: bug#54136: 29.0.50; Eshell emits extra prompts when killing processes in some cases
Date: Thu, 24 Feb 2022 13:03:36 +0200 [thread overview]
Message-ID: <834k4osf07.fsf@gnu.org> (raw)
In-Reply-To: <87y22038uz.fsf@gnus.org> (message from Lars Ingebrigtsen on Thu, 24 Feb 2022 10:35:32 +0100)
> From: Lars Ingebrigtsen <larsi@gnus.org>
> Date: Thu, 24 Feb 2022 10:35:32 +0100
> Cc: 54136@debbugs.gnu.org
>
> Jim Porter <jporterbugs@gmail.com> writes:
>
> > Ok, here's the patch with some tests.
>
> Thanks; pushed to Emacs 29.
The new tests fail on MS-Windows. Does the patch below look right?
I'm quite sure about the "sh" vs "sh.exe" part, but what about the
"killed" vs "interrupt" part? any idea why this happens on MS-Windows?
diff --git a/test/lisp/eshell/esh-proc-tests.el b/test/lisp/eshell/esh-proc-tests.el
index a8be0f8..3f67961 100644
--- a/test/lisp/eshell/esh-proc-tests.el
+++ b/test/lisp/eshell/esh-proc-tests.el
@@ -59,7 +59,7 @@ esh-proc-test/kill-pipeline
(eshell-wait-for-subprocess t)
(should (equal (buffer-substring-no-properties
output-start (eshell-end-of-output))
- "killed\n")))))
+ (or "interrupt\n" "killed\n"))))))
(ert-deftest esh-proc-test/kill-pipeline-head ()
"Test that killing the first process in a pipeline doesn't
@@ -88,4 +88,4 @@ esh-proc-test/kill-background-process
(kill-process (caar eshell-process-list))
;; Give `eshell-sentinel' a chance to run.
(sit-for 0.1)
- (eshell-match-result "\\[sh\\] [[:digit:]]+\n")))
+ (eshell-match-result "\\[sh\\(\\.exe\\)?\\] [[:digit:]]+\n")))
next prev parent reply other threads:[~2022-02-24 11:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-24 5:11 bug#54136: 29.0.50; Eshell emits extra prompts when killing processes in some cases Jim Porter
2022-02-24 5:16 ` Jim Porter
2022-02-24 9:35 ` Lars Ingebrigtsen
2022-02-24 11:03 ` Eli Zaretskii [this message]
2022-02-24 18:55 ` Jim Porter
2022-02-24 20:03 ` Eli Zaretskii
2022-02-24 20:07 ` Lars Ingebrigtsen
2022-02-25 1:04 ` Jim Porter
2022-02-25 2:18 ` Lars Ingebrigtsen
2022-02-25 7:09 ` Eli Zaretskii
2022-02-25 18:31 ` Jim Porter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=834k4osf07.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=54136@debbugs.gnu.org \
--cc=jporterbugs@gmail.com \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.