From: Eli Zaretskii <eliz@gnu.org>
To: Manuel Giraud <manuel@ledu-giraud.fr>
Cc: kfogel@red-bean.com, emacs-devel@gnu.org
Subject: Re: [PATCH] Fix bookmark-bmenu-list sorting.
Date: Fri, 04 Mar 2022 17:26:30 +0200 [thread overview]
Message-ID: <834k4divrt.fsf@gnu.org> (raw)
In-Reply-To: <874k4dlpeg.fsf@elite.giraud> (message from Manuel Giraud on Fri, 04 Mar 2022 16:15:51 +0100)
> From: Manuel Giraud <manuel@ledu-giraud.fr>
> Cc: kfogel@red-bean.com, emacs-devel@gnu.org
> Date: Fri, 04 Mar 2022 16:15:51 +0100
>
> > Or maybe you can show a simple recipe starting from "emacs -Q", then I
> > could see for myself what happened in Emacs 27 vs Emacs 28.
>
> This would do:
> --8<---------------cut here---------------start------------->8---
> (defun dobook (name)
> (with-current-buffer (get-buffer-create name)
> (set-visited-file-name (format "/tmp/%s" name))
> (bookmark-set (buffer-name))))
>
> (progn
> (dobook "a")
> (dobook "b"))
> --8<---------------cut here---------------end--------------->8---
>
> And then "M-x bookmark-bmenu-list". As bookmark "b" was the last
> defined, it should be at the top of the list… but I've just tested in
> Emacs 27.2 and the bookmark list was already alphabetically sorted. So I
> guess this is not a regression (and won't make it into 28 then).
OK, thanks.
One more question: your patch included this part:
> diff --git a/lisp/bookmark.el b/lisp/bookmark.el
> index 2751731817..80fb1cdfc7 100644
> --- a/lisp/bookmark.el
> +++ b/lisp/bookmark.el
> @@ -1819,7 +1819,7 @@ bookmark-bmenu--revert
> (list location))])
> entries)))
> (tabulated-list-init-header)
> - (setq tabulated-list-entries entries))
> + (setq tabulated-list-entries (reverse entries)))
> (tabulated-list-print t))
Why is that needed?
next prev parent reply other threads:[~2022-03-04 15:26 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-03 16:39 [PATCH] Fix bookmark-bmenu-list sorting Manuel Giraud
2022-03-03 17:41 ` Karl Fogel
2022-03-03 18:19 ` Eli Zaretskii
2022-03-04 3:13 ` Karl Fogel
2022-03-04 7:14 ` Eli Zaretskii
2022-03-04 8:18 ` Karl Fogel
2022-03-04 11:46 ` Eli Zaretskii
2022-03-04 13:25 ` Manuel Giraud
2022-03-04 13:33 ` Eli Zaretskii
2022-03-04 15:15 ` Manuel Giraud
2022-03-04 15:26 ` Eli Zaretskii [this message]
2022-03-04 17:41 ` Manuel Giraud
2022-03-04 19:37 ` Eli Zaretskii
2022-03-07 3:32 ` Karl Fogel
2022-03-07 9:21 ` Manuel Giraud
2022-03-20 23:40 ` Karl Fogel
2022-03-21 7:54 ` Manuel Giraud
2022-03-21 14:14 ` Karl Fogel
2022-04-20 18:09 ` [PATCH] Improve sorting in the bookmark list buffer Karl Fogel
2022-04-20 19:02 ` Eli Zaretskii
2022-04-20 19:49 ` Karl Fogel
2022-04-24 17:30 ` Karl Fogel
2022-04-24 18:13 ` Eli Zaretskii
2022-04-24 19:10 ` Karl Fogel
2022-04-25 9:35 ` Manuel Giraud
2022-04-25 17:50 ` Karl Fogel
2022-04-26 7:51 ` Manuel Giraud
2022-03-07 13:12 ` [PATCH] Fix bookmark-bmenu-list sorting Eli Zaretskii
2022-03-07 19:03 ` Karl Fogel
2022-03-07 5:17 ` Karl Fogel
2022-03-04 8:34 ` Manuel Giraud
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=834k4divrt.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=kfogel@red-bean.com \
--cc=manuel@ledu-giraud.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.